Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-10465 Improve jgroups stack-file configuration exceptions #7188

Merged
merged 1 commit into from Aug 6, 2019
Merged

ISPN-10465 Improve jgroups stack-file configuration exceptions #7188

merged 1 commit into from Aug 6, 2019

Conversation

ryanemerson
Copy link
Contributor

@tristantarrant tristantarrant merged commit 2023119 into infinispan:master Aug 6, 2019
@ryanemerson
Copy link
Contributor Author

@tristantarrant It looks like org.infinispan.remoting.jgroups.NonExistingJGroupsConfigTest.channelLookupTest was related. The test now fails with a NPE. Previously the exception was being wrapped as a CacheConfigurationExceptionand hence the test was passing. Not sure how best to handle this as when the cachemanager is created viaDefaultCacheManager(InputStream, boolean), the resourceResolver` is always null.

@ryanemerson ryanemerson mentioned this pull request Aug 13, 2019
Merged
@ryanemerson
Copy link
Contributor Author

Fixed by #7208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristantarrant tristantarrant Awaiting requested review from tristantarrant

Assignees
No one assigned
Labels
Trivial :-)
Projects
None yet
Milestone
No milestone
2 participants
@ryanemerson @tristantarrant