Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-10945 Remove protobuf and protoparser dependencies #7212

Closed
wants to merge 1 commit into from
Closed

ISPN-10945 Remove protobuf and protoparser dependencies #7212

wants to merge 1 commit into from

Conversation

pruivo
Copy link
Member

@pruivo pruivo commented Aug 22, 2019

@anistor
Copy link
Member

anistor commented Aug 22, 2019 •
edited

LGTM. These deps were never needed. They seem to have been added during a POM reorg. Perfectly fine to get rid of them.

anistor
anistor approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@anistor anistor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for CI.

@anistor
Copy link
Member

anistor commented Aug 22, 2019

integrated in master. thanks @pruivo !

@anistor anistor closed this Aug 22, 2019
@pruivo pruivo deleted the t_10495_10x branch July 10, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anistor anistor anistor approved these changes

Assignees
No one assigned
Labels
Trivial :-)
Projects
None yet
Milestone
No milestone
2 participants
@pruivo @anistor