Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-9599 Require ADMIN permission for getGlobalComponentRegistry #7222

Conversation

danberindei
Copy link
Member

https://issues.jboss.org/browse/ISPN-9599

  • Deprecate getGlobalComponentRegistry and getComponentRegistry
  • Require ADMIN permission for both
  • Require ADMIN permission for configuration getters
    (getCacheManagerConfiguration, getDefaultCacheConfiguration,
    getCacheConfiguration)
  • Remove some internal usages of the configuration getters

@tristantarrant
Copy link
Member

Unused imports

@danberindei danberindei force-pushed the ISPN-9599_globalcomponentregistry_permission branch 3 times, most recently from 2912b47 to 92b5fc9 Compare August 29, 2019 07:06
@danberindei
Copy link
Member Author

I fixed the import and fixed some failures caused by new features, let's see how it goes this time.

@danberindei danberindei force-pushed the ISPN-9599_globalcomponentregistry_permission branch 2 times, most recently from 7cf259d to 31d6f22 Compare August 30, 2019 14:37
@tristantarrant
Copy link
Member

@danberindei conflicts

@danberindei danberindei force-pushed the ISPN-9599_globalcomponentregistry_permission branch 3 times, most recently from 2184e4d to 17bf94a Compare September 2, 2019 07:31
* Deprecate getGlobalComponentRegistry and getComponentRegistry
* Require ADMIN permission for both
* Require ADMIN permission for configuration getters
  (getCacheManagerConfiguration, getDefaultCacheConfiguration,
  getCacheConfiguration)
* Remove some internal usages of the configuration getters
* Trust org.jboss.as.clustering.infinispan.* packages
@danberindei danberindei force-pushed the ISPN-9599_globalcomponentregistry_permission branch from 17bf94a to 8c1f1c0 Compare September 2, 2019 14:50
@tristantarrant tristantarrant merged commit 1ca09bd into infinispan:master Sep 3, 2019
@tristantarrant
Copy link
Member

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants