ISPN-10431 REST client library #7236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristantarrant
force-pushed
the
ISPN-10431/rest_client
branch
4 times, most recently
from
223535f
to
45f362a
Compare
|
LGTM, waiting for CI |
|
failures unrelated |
|
Conflicts |
tristantarrant
force-pushed
the
ISPN-10431/rest_client
branch
from
45f362a
to
c8bb478
Compare
|
Rebased |
|
@gustavonalle failures unrelated |
|
merged, thanks @tristantarrant ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-10431
this will be needed by the new CLI and I've refactored the server testsuite to use this.
I've decided to go with OkHttp 3.x because:
The backend can be replaced in the future (either Apache HC 5 when it becomes final or the JDK HttpClient when we baseline on JDK 11)
I've implemented support for Basic, Digest and Bearer authentication
I've left the Netty test client in the rest testsuite since it allows us to fine-tune some things like sending HTTP Upgrade headers even in plain text.