Remove infinispan-jboss-marshalling from query #7388
Conversation
ryanemerson
force-pushed
the
ISPN-10591-query
branch
from
f5964d9
to
963bf22
Compare
ryanemerson
force-pushed
the
ISPN-10591-query
branch
from
963bf22
to
804feb5
Compare
ryanemerson
force-pushed
the
ISPN-10591-query
branch
from
804feb5
to
01e2f4a
Compare
ryanemerson
requested review from
anistor and
gustavocoding
and removed request for
anistor
| @@ -207,7 +226,8 @@ public void writeObject(ObjectOutput output, QueryDefinition queryDefinition) th | |||
| output.writeObject(queryDefinition.queryEngineProvider); | |||
| } else { | |||
| output.writeBoolean(false); | |||
| output.writeObject(queryDefinition.hsQuery); | |||
| output.writeObject(queryDefinition.hsQuery.getLuceneQuery()); | |||
There was a problem hiding this comment.
What about the other serializable parts of hsQuery?
There was a problem hiding this comment.
Do you have any fields in mind? Looking at the non-transient fields in LuceneHSQuery impl I don't think we need to marshall any of the fields other than the LuceneQuery in order to recreate the state.
There was a problem hiding this comment.
That are other types of hsQuery unfortunately. I am a bit puzzled no test failed by ignoring the serialization of the other stuff, let me check...
There was a problem hiding this comment.
That are other types of hsQuery unfortunately.
True, that's actually partly why I thought that recreating the HSQuery via the LuceneQuery and SearchIntegrator.createHSQuery was sufficient, as the SearchIntegrator only provides createHSQuery(Query, Class<?>...) and createHSQuery(Query, IndexedTypeMap<CustomTypeMetadata>).
There was a problem hiding this comment.
// Internal and experimental! Creates a {@link CacheQuery}, filtered according to the given {@link HSQuery}
SearchManagerImpl#getQuery(HSQuery hSearchQuery, IndexedQueryMode queryMode)That's where it is used. It's an internal stuff, not part of the SearchManager interface
There was a problem hiding this comment.
So if someone is using this, it has already been warned :) WDYT @anistor ? Are you happy with not supporting this method from a user's POV, and keep it only working to the internal callers?
|
merged. thanks @ryanemerson ! |
https://issues.jboss.org/browse/ISPN-10591
Please don't close the Jira as more PRs to come.