ISPN-10558 ServerNG add database rules #7436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristantarrant
force-pushed
the
ISPN-10558/server_db_tests
branch
3 times, most recently
from
d561fa9
to
5cb32e8
Compare
tristantarrant
force-pushed
the
ISPN-10558/server_db_tests
branch
2 times, most recently
from
ce14ac7
to
fa25141
Compare
gustavolira
approved these changes
Oct 16, 2019
server/runtime/src/test/java/org/infinispan/server/test/persistence/DatabaseServerRule.java
Outdated
Show resolved
Hide resolved
server/runtime/src/test/java/org/infinispan/server/persistence/PooledConnectionOperations.java
Outdated
Show resolved
Hide resolved
server/runtime/src/test/resources/configuration/datasource/mariadb.properties
Outdated
Show resolved
Hide resolved
...ain/java/org/infinispan/persistence/jdbc/impl/connectionfactory/PooledConnectionFactory.java
Show resolved
Hide resolved
tristantarrant
force-pushed
the
ISPN-10558/server_db_tests
branch
from
fa25141
to
07596e1
Compare
|
Failures in the new test class https://ci.infinispan.org/job/Infinispan/job/PR-7436/6/#showFailuresLink |
tristantarrant
force-pushed
the
ISPN-10558/server_db_tests
branch
from
07596e1
to
e4464eb
Compare
|
The test was failing because of an old version of docker on the agents. I have upgraded it. |
|
@wburns CI is now fixed (after Docker upgrade) |
tristantarrant
force-pushed
the
ISPN-10558/server_db_tests
branch
from
e4464eb
to
cc25909
Compare
ryanemerson
reviewed
Oct 18, 2019
persistence/jdbc/src/main/java/org/infinispan/persistence/jdbc/DatabaseType.java
Outdated
Show resolved
Hide resolved
ryanemerson
requested changes
Oct 18, 2019
wburns
reviewed
Oct 18, 2019
|
|
||
| ## Testsuite Properties | ||
|
|
||
| The following is a list of properties which affect the build: | ||
|
|
||
| * `org.infinispan.test.server.baseImageName` the base image to use for the server. Defaults to `jboss/base-jdk:11`. | ||
| * `org.infinispan.test.server.driver` the driver to use, `EMBEDDED` or `CONTAINER`. Defaults to the `EMBEDDED` driver. | ||
| * `org.infinispan.test.server.extension.libs` locates artifact defined by G:A:V, you can pass a list of libraries (comma separeted) to be copied to the server. Only needed for container mode. | ||
| * `org.infinispan.test.server.jdbc.databases` database name to be used during persistence tests. |
There was a problem hiding this comment.
Suggested change
| * `org.infinispan.test.server.jdbc.databases` database name to be used during persistence tests. | |
| * `org.infinispan.test.server.jdbc.databases` database types to be used during persistence tests |
server/runtime/src/test/java/org/infinispan/server/test/category/Persistence.java
Show resolved
Hide resolved
server/runtime/src/test/java/org/infinispan/server/test/persistence/DatabaseServerRule.java
Outdated
Show resolved
Hide resolved
|
Whoops thought I submitted these yesterday |
tristantarrant
force-pushed
the
ISPN-10558/server_db_tests
branch
from
cc25909
to
8eaa74e
Compare
tristantarrant
force-pushed
the
ISPN-10558/server_db_tests
branch
from
8eaa74e
to
1c2edf5
Compare
|
Included the shrinkwrap upgrade as well as the MariaDB fix |
|
Thanks @gustavolira @tristantarrant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-10558
This now runs server DB tests against containerized H2, MySQL and PostgreSQL.