ISPN-10975 Transactional cache will slow down the expiration reaper #7610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfink
reviewed
Nov 30, 2019
| CompletableFuture<Void> future; | ||
| if (transactional) { | ||
| // Transactional is still blocking - to be removed later | ||
| future = CompletableFuture.supplyAsync(() -> cacheToUse.removeLifespanExpired(key, value, lifespan), asyncExecutor) |
There was a problem hiding this comment.
There is a NullPointer with this fix if the reaper is executed
There was a problem hiding this comment.
Should be fixed now; added the missing @Inject
wburns
force-pushed
the
expiration_non_blocking_transaction
branch
from
c965ec9
to
916ad8c
Compare
wburns
force-pushed
the
expiration_non_blocking_transaction
branch
from
916ad8c
to
362593b
Compare
wburns
changed the title
danberindei
reviewed
Dec 6, 2019
| CompletableFuture<Void> future = cacheToUse.removeLifespanExpired(key, value, lifespan); | ||
| CompletableFuture<Void> future; | ||
| if (transactional) { | ||
| // Transactional is still blocking - to be removed later |
There was a problem hiding this comment.
IMO we could make cache.removeLifespanExpired() submit a task to an executor internally when it's not part of a transaction, but the only way to make it realy non-blocking is to avoid any interaction with JTA, at which point we might as well remove it from the AdvancedCache API.
There was a problem hiding this comment.
Yeah, I think we may have to remove it from the API to more cleanly fix this in the future. This is mostly just a stop gap until that can be done.
danberindei
approved these changes
Dec 6, 2019
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-10975