Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-11001 Get config templates #7637

Merged
merged 1 commit into from Dec 5, 2019
Merged

Conversation

karesti
Copy link
Contributor

@karesti karesti commented Dec 2, 2019

Copy link

@gustavocoding gustavocoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karesti I though you'd filter the templates out of /v2/cache-managers/{name}/cache-configs by having a parameter, like /v2/cache-managers/{name}/cache-configs?ignore-templates or something similar, but this PR instead created another method to bring only the templates?

@oraNod
Copy link
Contributor

oraNod commented Dec 3, 2019

@karesti hey, added a commit with suggested edit. hope that's ok. cheers!

@karesti
Copy link
Contributor Author

karesti commented Dec 3, 2019

@gustavonalle yes, I was thinking more on the cache-configs/templates like a filter instead a parameter.
I can change that if you want definetly

@karesti
Copy link
Contributor Author

karesti commented Dec 3, 2019

@oraNod thanks for the doc Don!

* templates only method
* bring configs in order
@gustavocoding
Copy link

ok, I was confused with the purpose of the PR, but @karesti has clarified.

@karesti
Copy link
Contributor Author

karesti commented Dec 3, 2019

@gustavonalle I will ping you when the build is over for merge, thanks!!

@karesti
Copy link
Contributor Author

karesti commented Dec 5, 2019

@gustavonalle you can merge, failures are unrelated

@gustavocoding gustavocoding merged commit dd7488a into infinispan:master Dec 5, 2019
@gustavocoding
Copy link

merged, thanks @karesti

@karesti karesti deleted the ISPN-11001 branch December 5, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants