Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-11054 Fail if we cannot recursively delete a directory during tests #7658

Merged
merged 1 commit into from Dec 17, 2019
Merged

ISPN-11054 Fail if we cannot recursively delete a directory during tests #7658

merged 1 commit into from Dec 17, 2019

Conversation

tristantarrant
Copy link
Member

@tristantarrant tristantarrant commented Dec 6, 2019 •
edited

danberindei
danberindei suggested changes Dec 6, 2019
View reviewed changes
Copy link
Member

@danberindei danberindei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking, but that's what you get when you reformat perfectly good comments :)

commons/src/main/java/org/infinispan/commons/util/Util.java Outdated Show resolved Hide resolved
commons/src/main/java/org/infinispan/commons/util/Util.java Outdated Show resolved Hide resolved
@tristantarrant tristantarrant changed the title Fail if we cannot recursively delete a directory during tests ISPN-11054 Fail if we cannot recursively delete a directory during tests Dec 9, 2019
@tristantarrant
Copy link
Member Author

@danberindei I repushed the commit without the formatting changes and I've also created a Jira

@ryanemerson ryanemerson merged commit 4c08b74 into infinispan:master Dec 17, 2019
@ryanemerson
Copy link
Contributor

Thanks @tristantarrant

@tristantarrant tristantarrant deleted the fail_if_cannot_delete branch January 21, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danberindei danberindei danberindei requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tristantarrant @ryanemerson @danberindei