ISPN-11106 Export 'base' and 'vendor' microprofile metric registries #7696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristantarrant
requested changes
Dec 19, 2019
| try { | ||
| jmxRegistrar.init(); | ||
| } catch (Exception e) { | ||
| //throw new IllegalStateException("Failed to initialize base and vendor metrics from JMX MBeans", e); |
There was a problem hiding this comment.
I assume that this should be at least a WARN?
There was a problem hiding this comment.
Oops. No, it should be an ERROR and I wonder why I commented it out. Will fix asap.
anistor
force-pushed
the
t_ISPN-11106_m
branch
from
3db9679
to
0023294
Compare
anistor
force-pushed
the
t_ISPN-11106_m
branch
from
0023294
to
f602308
Compare
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-11106