ISPN-11153 When starting the server all failures should be handled #7734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| loggingFile = new File(confDir, Server.DEFAULT_LOGGING_FILE); | ||
| } else if (!loggingFile.isAbsolute()) { | ||
| loggingFile = Paths.get(confDir.getPath(), loggingFile.getPath()).toFile(); | ||
| } |
There was a problem hiding this comment.
None of this code can fail so it makes no sense to move it inside the try/catch
|
I don't think that a broken logging configuration should fail the server. |
| List<String> errors = new ArrayList<>(0); | ||
|
|
||
| // the listener call will be in the same getLogger thread | ||
| StatusConsoleListener listener = new StatusConsoleListener(Level.ERROR) { |
There was a problem hiding this comment.
instead of using the listener, you can inspect the logger output:
StatusLogger.getLogger().getStatusData() .stream() .filter(s -> s.getLevel().isMoreSpecificThan(Level.ERROR)) .forEach(// log to stderr );
|
The bash won't be hanged. It will print only ERRROR messages to the output. That is default log4j configuration. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-11153