Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-1666 & ISPN-1667 add access to configuration #783

Closed
wants to merge 1 commit into from
Closed

ISPN-1666 & ISPN-1667 add access to configuration #783

wants to merge 1 commit into from

Conversation

pmuir
Copy link
Contributor

@pmuir pmuir commented Jan 5, 2012

@maniksurtani maniksurtani reopened this Jan 5, 2012
@maniksurtani
Copy link
Member

This breaks the build:


[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /Users/manik/Code/infinispan/upstream/client/hotrod-client/src/test/java/org/infinispan/client/hotrod/ClientSocketReadTimeoutTest.java:[106,18] org.infinispan.client.hotrod.ClientSocketReadTimeoutTest.HangingCacheManager is not abstract and does not override abstract method getCacheConfiguration(java.lang.String) in org.infinispan.manager.EmbeddedCacheManager
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Infinispan Common Parent .......................... SUCCESS [2.573s]
[INFO] Infinispan Core ................................... SUCCESS [39.110s]
[INFO] Infinispan Tools .................................. SUCCESS [2.988s]
[INFO] Infinispan Query API .............................. SUCCESS [4.134s]
[INFO] Parent pom for cachestore modules ................. SUCCESS [0.706s]
[INFO] Infinispan JDBM CacheStore ........................ SUCCESS [4.419s]
[INFO] Infinispan Tree API ............................... SUCCESS [4.153s]
[INFO] Infinispan JDBC CacheStore ........................ SUCCESS [2.495s]
[INFO] Infinispan Lucene Directory Implementation ........ SUCCESS [2.695s]
[INFO] Infinispan BDBJE CacheStore ....................... SUCCESS [2.066s]
[INFO] Infinispan CloudCacheStore ........................ SUCCESS [3.595s]
[INFO] Parent pom for server modules ..................... SUCCESS [0.295s]
[INFO] Infinispan Server - Core Components ............... SUCCESS [25.137s]
[INFO] Infinispan Hot Rod Server ......................... SUCCESS [42.816s]
[INFO] Infinispan Hot Rod Client ......................... FAILURE [1.456s]
[INFO] Infinispan remote CacheStore ...................... SKIPPED
[INFO] Infinispan CassandraCacheStore .................... SKIPPED
[INFO] Infinispan Memcached Server ....................... SKIPPED
[INFO] Infinispan WebSocket Server ....................... SKIPPED
[INFO] Infinispan REST Server ............................ SKIPPED
[INFO] Infinispan RHQ Plugin ............................. SKIPPED
[INFO] Infinispan Spring Integration ..................... SKIPPED
[INFO] Infinispan GUI Demo ............................... SKIPPED
[INFO] Infinispan EC2 Demo ............................... SKIPPED
[INFO] Infinispan Distributed Executors and Map/Reduce Demo  SKIPPED
[INFO] Infinispan EC2 Demo UI ............................ SKIPPED
[INFO] Infinispan Directory Demo ......................... SKIPPED
[INFO] Infinispan Lucene Directory Demo .................. SKIPPED
[INFO] Infinispan GridFileSystem WebDAV interface ........ SKIPPED
[INFO] Infinispan Near Cache Demo ........................ SKIPPED
[INFO] Infinispan CDI support ............................ SKIPPED
[INFO] Infinispan Near Cache Demo Client ................. SKIPPED
[INFO] Infinispan CDI support JCache TCK runner .......... SKIPPED
[INFO] Infinispan Distribution ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2:21.092s
[INFO] Finished at: Thu Jan 05 15:11:48 GMT 2012
[INFO] Final Memory: 49M/307M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:testCompile (default-testCompile) on project infinispan-client-hotrod: Compilation failure
[ERROR] /Users/manik/Code/infinispan/upstream/client/hotrod-client/src/test/java/org/infinispan/client/hotrod/ClientSocketReadTimeoutTest.java:[106,18] org.infinispan.client.hotrod.ClientSocketReadTimeoutTest.HangingCacheManager is not abstract and does not override abstract method getCacheConfiguration(java.lang.String) in org.infinispan.manager.EmbeddedCacheManager

@pmuir
Copy link
Contributor Author

pmuir commented Jan 5, 2012

Pull updated :-)

maniksurtani
maniksurtani reviewed Jan 5, 2012
View reviewed changes
...nt/hotrod-client/src/test/java/org/infinispan/client/hotrod/ClientSocketReadTimeoutTest.java
@Override
public org.infinispan.configuration.global.GlobalConfiguration getCacheManagerConfiguration() {
return delegate.getCacheManagerConfiguration();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this class just extend AbstractDelegatingEmbeddedCacheManager ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want me to do that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if that works - will make life easier in future when adding to the EmbeddedCacheManager interface.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I'll take it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just done it, testing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pmuir @maniksurtani