ISPN-11280 ConcurrentModificationException in ConditionFuture #7853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pruivo
requested changes
Feb 11, 2020
core/src/main/java/org/infinispan/util/concurrent/ConditionFuture.java
Outdated
Show resolved
Hide resolved
danberindei
force-pushed
the
ISPN-11280_ConditionFuture
branch
from
0136e86
to
1055267
Compare
pruivo
approved these changes
Feb 14, 2020
|
integrated! thanks @danberindei ! |
johnou
reviewed
Feb 14, 2020
| } | ||
|
|
||
| public void stop() { | ||
| running = false; | ||
| lastValue = null; | ||
|
|
||
| List<CompletableFuture<?>> completed; |
There was a problem hiding this comment.
@danberindei how about something like this to cut down on the sync scope?
final List<Data> copy;
synchronized (futures) {
copy = new ArrayList<>(futures.values());
futures.clear();
}
for (Data data : copy) {
data.cancelFuture.cancel(false);
}
johnou
reviewed
Feb 14, 2020
| data.completeExceptionally(e); | ||
| } catch (Throwable t) { | ||
| List<CompletableFuture<?>> completed; | ||
| synchronized (futures) { |
There was a problem hiding this comment.
same sync optimisation can be applied here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-11280
https://issues.redhat.com/browse/ISPN-11296