ISPN-11345 Introduce integration tests for serverNG #7912

diegolovison · 2020-02-18T05:17:17Z

https://issues.redhat.com/browse/ISPN-11345

Support Arquillian
Arquillian is optional
Support multiple Infinispan Servers
Support Infinispan CONTAINER driver

Support Arquillian
Allow running the test in Wildfly or Tomcat

Arquillian is optional
We can run the test without deploying it in Wildfly or Tomcat. It runs faster.

Support multiple Infinispan Servers
As a QE, I would like to create a test scenario using multiple Infinispan Servers.

Support Infinispan CONTAINER driver
Infinispan Servers will be running in a container.

tristantarrant · 2020-02-18T15:48:33Z

Please wait while I work on extracting the Infinispan Server Test Driver to its own module

server/runtime/src/test/java/org/infinispan/server/test/InfinispanServerDriver.java

server/integration/src/test/java/org/infinispan/server/integration/HotRodRemoteCacheIT.java

server/integration/src/test/resources/ispn-config/infinispan.xml

gustavolira · 2020-02-18T12:07:58Z

server/integration/src/test/java/org/infinispan/server/integration/DeploymentBuilder.java

+
+      ArquillianServer server = ArquillianServer.valueOf(System.getProperty("infinispan.server.integration.launch").toUpperCase());
+      WebArchive war = ShrinkWrap.create(WebArchive.class, "infinispan-server-integration.war");
+      if (ArquillianServer.TOMCAT9.equals(server)) {


Just a NIT, instead of use if/else if/else in this case you can use swtich

switch (server) { case TOMCAT9: tomcat9(war); break; case WILDFLY18: wildfly18(war); break; default: throw new IllegalStateException(String.format("%s not supported", server)); }

diegolovison · 2020-03-02T13:33:27Z

We now support be able to run the tests with and without Arquillian

dlovison@Diegos-MacBook-Pro infinispan % mvn verify -pl server/integration -Pwildfly18 | grep HotRodRemoteCacheIT
[INFO] Running org.infinispan.server.integration.HotRodRemoteCacheIT
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.964 s - in org.infinispan.server.integration.HotRodRemoteCacheIT

dlovison@Diegos-MacBook-Pro infinispan % mvn verify -pl server/integration -Ptomcat9 | grep HotRodRemoteCacheIT
[INFO] Running org.infinispan.server.integration.HotRodRemoteCacheIT
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.451 s - in org.infinispan.server.integration.HotRodRemoteCacheIT

dlovison@Diegos-MacBook-Pro infinispan % mvn verify -pl server/integration | grep HotRodRemoteCacheIT 
[INFO] Running org.infinispan.server.integration.HotRodRemoteCacheIT
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.084 s - in org.infinispan.server.integration.HotRodRemoteCacheIT

diegolovison · 2020-04-08T00:15:26Z

It is ready for review

tristantarrant

You should work against master instead of 10.1.x.
Also I tried to build it but it fails with the following errors:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project infinispan-server-integration: Compilation failure: Compilation failure: 
[ERROR] /home/tst/Work/Infinispan/infinispan/server/integration/src/main/java/org/infinispan/server/integration/enricher/Enricher.java:[35,41] cannot find symbol
[ERROR]   symbol:   variable REMOTE_CONTAINER
[ERROR]   location: class org.infinispan.server.test.core.ServerRunMode
[ERROR] /home/tst/Work/Infinispan/infinispan/server/integration/src/main/java/org/infinispan/server/integration/enricher/Enricher.java:[38,26] cannot find symbol
[ERROR]   symbol:   method before(java.lang.String)
[ERROR]   location: variable serverRule of type org.infinispan.server.integration.enricher.Enricher.RemoteInfinispanServerRule
[ERROR] /home/tst/Work/Infinispan/infinispan/server/integration/src/main/java/org/infinispan/server/integration/enricher/Enricher.java:[41,46] method before in class org.infinispan.server.test.junit4.InfinispanServerTestMethodRule cannot be applied to given types;
[ERROR]   required: no arguments
[ERROR]   found:    java.lang.String,java.lang.String
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /home/tst/Work/Infinispan/infinispan/server/integration/src/main/java/org/infinispan/server/integration/enricher/Enricher.java:[55,46] cannot find symbol
[ERROR]   symbol:   method getInfinispanServerRule()
[ERROR]   location: variable infinispanServerTestMethodRule of type org.infinispan.server.test.junit4.InfinispanServerTestMethodRule
[ERROR] /home/tst/Work/Infinispan/infinispan/server/integration/src/main/java/org/infinispan/server/integration/enricher/Enricher.java:[56,46] after() has private access in org.infinispan.server.test.junit4.InfinispanServerTestMethodRule
[ERROR] /home/tst/Work/Infinispan/infinispan/server/integration/src/main/java/org/infinispan/server/integration/enricher/Enricher.java:[68,7] method does not override or implement a method from a supertype
[ERROR] /home/tst/Work/Infinispan/infinispan/server/integration/src/main/java/org/infinispan/server/integration/enricher/Enricher.java:[70,14] serverDriver has private access in org.infinispan.server.test.junit4.InfinispanServerRule
[ERROR] /home/tst/Work/Infinispan/infinispan/server/integration/src/main/java/org/infinispan/server/integration/enricher/Enricher.java:[70,30] configuration has private access in org.infinispan.server.test.junit4.InfinispanServerRule
[ERROR] /home/tst/Work/Infinispan/infinispan/server/integration/src/main/java/org/infinispan/server/integration/enricher/Enricher.java:[70,43] cannot find symbol
[ERROR]   symbol:   method newDriver()
[ERROR]   location: variable configuration of type org.infinispan.server.test.core.InfinispanServerTestConfiguration
[ERROR] /home/tst/Work/Infinispan/infinispan/server/integration/src/main/java/org/infinispan/server/integration/InfinispanServerIntegrationProcessorExecuter.java:[55,28] before(java.lang.String) has private access in org.infinispan.server.test.junit4.InfinispanServerRule
[ERROR] /home/tst/Work/Infinispan/infinispan/server/integration/src/main/java/org/infinispan/server/integration/InfinispanServerIntegrationProcessorExecuter.java:[65,19] after(java.lang.String) has private access in org.infinispan.server.test.junit4.InfinispanServerRule
[ERROR] -> [Help 1]

tristantarrant · 2020-04-20T08:20:04Z

server/integration/src/main/java/org/infinispan/server/integration/ArquillianServerType.java

+
+public enum ArquillianServerType {
+
+   NONE, TOMCAT9, WILDFLY18;


We should remove the version from the identifiers.

tristantarrant · 2020-04-20T08:20:29Z

server/integration/pom.xml

+
+    <properties>
+        <version.tomcat>9.0.11</version.tomcat>
+        <version.wildfly>18.0.1.Final</version.wildfly>


tristantarrant · 2020-04-20T08:27:11Z

server/integration/src/main/java/org/infinispan/server/integration/DeploymentBuilder.java

+      WebArchive war = ShrinkWrap.create(WebArchive.class, "infinispan-server-integration.war");
+      addDefaultTestLib(war);
+      ArquillianServerType arquillianServerType = ArquillianServerType.current();
+      if (ArquillianServerType.TOMCAT9.equals(arquillianServerType)) {


Prefer a switch/case

tristantarrant · 2020-04-20T08:33:13Z

...ain/java/org/infinispan/server/integration/InfinispanServerIntegrationProcessorExecuter.java

+/*
+ * It starts the ServerRunMode.CONTAINER in the client side
+ */
+public class InfinispanServerIntegrationProcessorExecuter {


s/Executer/Executor/

diegolovison · 2020-05-07T15:11:30Z

I am waiting for #8173 get merged and then will work in the master branch

diegolovison · 2020-05-11T14:18:13Z

I am waiting for #8297 get merged and then will work in the master branch

danberindei · 2020-05-24T10:09:21Z

Please rebase on master. You can also edit the PR and change the base to master, no need to open a new one.

diegolovison · 2020-06-02T11:50:27Z

I am going to follow https://github.com/infinispan/infinispan/tree/master/integrationtests/wildfly-modules that will simplify a lot the code

diegolovison added the Backport label Feb 18, 2020

diegolovison force-pushed the ISPN-11345/10x branch 2 times, most recently from dde8ba9 to ba94d13 Compare February 18, 2020 05:54

diegolovison mentioned this pull request Feb 19, 2020

ISPN-11370 Server Test Driver #7920

Merged

diegolovison force-pushed the ISPN-11345/10x branch 2 times, most recently from ea7c89c to 5716229 Compare February 19, 2020 17:37

diegolovison commented Feb 19, 2020

View reviewed changes

server/runtime/src/test/java/org/infinispan/server/test/InfinispanServerDriver.java Outdated Show resolved Hide resolved

diegolovison force-pushed the ISPN-11345/10x branch from 5716229 to 47f6b7c Compare February 19, 2020 19:59

diegolovison added the Preview label Feb 19, 2020

diegolovison commented Feb 19, 2020

View reviewed changes

server/integration/src/test/java/org/infinispan/server/integration/HotRodRemoteCacheIT.java Show resolved Hide resolved

gustavolira reviewed Feb 19, 2020

View reviewed changes

diegolovison force-pushed the ISPN-11345/10x branch from 47f6b7c to 8b2c097 Compare February 24, 2020 12:56

diegolovison force-pushed the ISPN-11345/10x branch from 8b2c097 to 29d9f59 Compare March 2, 2020 13:32

diegolovison force-pushed the ISPN-11345/10x branch 13 times, most recently from 22d5819 to 51857d3 Compare March 3, 2020 01:51

diegolovison force-pushed the ISPN-11345/10x branch 2 times, most recently from 4db8e38 to a9e360b Compare March 10, 2020 02:23

diegolovison force-pushed the ISPN-11345/10x branch 9 times, most recently from 8622845 to 3002046 Compare March 13, 2020 18:42

diegolovison force-pushed the ISPN-11345/10x branch 2 times, most recently from 4211c45 to 600ff91 Compare March 27, 2020 18:00

diegolovison force-pushed the ISPN-11345/10x branch 3 times, most recently from 0e05667 to 62ac5ce Compare April 8, 2020 00:11

ISPN-11345 Introduce integration tests for serverNG

701dbf0

diegolovison force-pushed the ISPN-11345/10x branch from 62ac5ce to 701dbf0 Compare April 8, 2020 00:14

diegolovison removed the Preview label Apr 8, 2020

tristantarrant requested changes Apr 20, 2020

View reviewed changes

ryanemerson added the Changes Required label Apr 23, 2020

diegolovison added On Hold Needs Rebase labels May 7, 2020

diegolovison closed this Jun 2, 2020

diegolovison deleted the ISPN-11345/10x branch June 2, 2020 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ISPN-11345 Introduce integration tests for serverNG #7912

ISPN-11345 Introduce integration tests for serverNG #7912

diegolovison commented Feb 18, 2020 •

edited

tristantarrant commented Feb 18, 2020

gustavolira Feb 18, 2020

diegolovison commented Mar 2, 2020 •

edited

diegolovison commented Apr 8, 2020

tristantarrant left a comment

tristantarrant Apr 20, 2020

tristantarrant Apr 20, 2020

tristantarrant Apr 20, 2020

tristantarrant Apr 20, 2020

diegolovison commented May 7, 2020

diegolovison commented May 11, 2020

danberindei commented May 24, 2020

diegolovison commented Jun 2, 2020

ISPN-11345 Introduce integration tests for serverNG #7912

ISPN-11345 Introduce integration tests for serverNG #7912

Conversation

diegolovison commented Feb 18, 2020 • edited

tristantarrant commented Feb 18, 2020

gustavolira Feb 18, 2020

Choose a reason for hiding this comment

diegolovison commented Mar 2, 2020 • edited

diegolovison commented Apr 8, 2020

tristantarrant left a comment

Choose a reason for hiding this comment

tristantarrant Apr 20, 2020

Choose a reason for hiding this comment

tristantarrant Apr 20, 2020

Choose a reason for hiding this comment

tristantarrant Apr 20, 2020

Choose a reason for hiding this comment

tristantarrant Apr 20, 2020

Choose a reason for hiding this comment

diegolovison commented May 7, 2020

diegolovison commented May 11, 2020

danberindei commented May 24, 2020

diegolovison commented Jun 2, 2020

diegolovison commented Feb 18, 2020 •

edited

diegolovison commented Mar 2, 2020 •

edited