Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-11393 statistics, metrics, jmx #7979

Merged
merged 1 commit into from Mar 12, 2020
Merged

ISPN-11393 statistics, metrics, jmx #7979

merged 1 commit into from Mar 12, 2020

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Mar 2, 2020

@oraNod oraNod requested a review from anistor March 2, 2020 20:27
@oraNod oraNod added the Documentation Pull request containing only documentation changes label Mar 2, 2020
@oraNod oraNod requested a review from diegolovison March 2, 2020 20:33
@anistor
Copy link
Member

anistor commented Mar 3, 2020

Looking...

@oraNod oraNod changed the title ISPN-11402 statistics, metrics, jmx ISPN-11393 statistics, metrics, jmx Mar 3, 2020
@oraNod oraNod force-pushed the ISPN-11393 branch 3 times, most recently from e53c235 to 386b225 Compare March 10, 2020 09:47
@oraNod oraNod requested a review from anistor March 11, 2020 16:43
anistor
anistor suggested changes Mar 11, 2020
View reviewed changes
Copy link
Member

@anistor anistor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added another bunch of comments. I think I'm about 90% done. Please fix these and then I'll read everything again on the rendered doc.

documentation/src/main/asciidoc/topics/proc_collecting_metrics.adoc Outdated Show resolved Hide resolved
documentation/src/main/asciidoc/topics/proc_configuring_hotrod_jmx.adoc Outdated Show resolved Hide resolved
documentation/src/main/asciidoc/topics/proc_configuring_hotrod_jmx.adoc Show resolved Hide resolved
documentation/src/main/asciidoc/topics/proc_naming_cache_managers.adoc Outdated Show resolved Hide resolved
@oraNod
Copy link
Contributor Author

oraNod commented Mar 11, 2020

I've added another bunch of comments. I think I'm about 90% done. Please fix these and then I'll read everything again on the rendered doc.

thanks @anistor this is a really good review. I've learned a few things here. the changes are in and I've updated the rendered doc.

@oraNod oraNod requested a review from anistor March 11, 2020 19:38
@anistor anistor merged commit 88da801 into infinispan:master Mar 12, 2020
@anistor
Copy link
Member

anistor commented Mar 12, 2020

Merged in master @oraNod ! Thanks!

@anistor
Copy link
Member

anistor commented Mar 12, 2020 •
edited

While reviewing the docs (and also looking at what the code actually does, just to make sure) I found this https://issues.redhat.com/browse/ISPN-11463
This has a bit of impact on docs also. Fixing this bug means no more zeros are exported for mp metrics with stats disabled, those metrics no longer get registered, but 0s will still be exported via JMX.

@oraNod oraNod deleted the ISPN-11393 branch January 24, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolovison diegolovison Awaiting requested review from diegolovison

@anistor anistor Awaiting requested review from anistor

Assignees
No one assigned
Labels
Documentation Pull request containing only documentation changes
Projects
None yet
Milestone
No milestone
2 participants
@oraNod @anistor