Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-11480 Call EmbeddedCacheManager#stop in shutdown hook #8063

Merged
merged 3 commits into from Mar 25, 2020
Merged

ISPN-11480 Call EmbeddedCacheManager#stop in shutdown hook #8063

merged 3 commits into from Mar 25, 2020

Conversation

ryanemerson
Copy link
Contributor

@ryanemerson ryanemerson commented Mar 17, 2020 •
edited

@ryanemerson ryanemerson force-pushed the ISPN-11480 branch 2 times, most recently from 18c8955 to 6ef4502 Compare March 19, 2020 10:39
@ryanemerson
Copy link
Contributor Author

Updated

@ryanemerson ryanemerson mentioned this pull request Mar 24, 2020
Merged
wburns
wburns reviewed Mar 25, 2020
View reviewed changes
server/runtime/src/main/java/org/infinispan/server/Server.java
// Shutdown Log4jk context manually as we set shutdownHook="disable"
// Log4j's shutdownHook may run concurrently with our shutdownHook,
// disabling logging before the server has finished stopping.
LogManager.shutdown();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess I never knew we required log4j in the server.

@wburns wburns merged commit 2393851 into infinispan:master Mar 25, 2020
@wburns
Copy link
Member

wburns commented Mar 25, 2020

Integrated into master, thanks @ryanemerson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danberindei danberindei danberindei left review comments

@wburns wburns wburns left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ryanemerson @wburns @danberindei