ISPN-11511 More consistent branding #8082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristantarrant
force-pushed
the
ISPN-11511/branding_banner
branch
from
03c5eac
to
5ccc7cb
Compare
|
Rebased |
pruivo
reviewed
Mar 24, 2020
| @@ -161,7 +168,7 @@ public static void printFullVersionInformation() { | |||
| * Returns version information as a string. | |||
| */ | |||
| public static String printVersion() { | |||
| return INSTANCE.brandname + " '" + INSTANCE.codename + "' " + INSTANCE.version; | |||
| return INSTANCE.brandName + " '" + INSTANCE.codename + "' " + INSTANCE.version; | |||
There was a problem hiding this comment.
I think it should be Infinispan instead of the brand name.
Suggested change
| return INSTANCE.brandName + " '" + INSTANCE.codename + "' " + INSTANCE.version; | |
| return "Infinispan '" + INSTANCE.codename + "' " + INSTANCE.version; |
This is used in CLI (version command) and it is logged when the server starts:
ISPN000128: Infinispan version: My Brand 'N/A' 11.0.0-SNAPSHOT
There was a problem hiding this comment.
or change its format:
<brand> <brand_version> (Infinispan <project_version>)
There was a problem hiding this comment.
May I suggest to move the codename to the end and use the brand version instead:
Suggested change
| return INSTANCE.brandName + " '" + INSTANCE.codename + "' " + INSTANCE.version; | |
| return INSTANCE.brandName + " " + INSTANCE.brandVersion + " (" + INSTANCE.codename + ")"; |
pruivo
reviewed
Mar 24, 2020
server/runtime/src/main/java/org/infinispan/server/logging/Log.java
Outdated
Show resolved
Hide resolved
pruivo
reviewed
Apr 3, 2020
commons/all/src/main/java/org/infinispan/commons/util/Version.java
Outdated
Show resolved
Hide resolved
tristantarrant
force-pushed
the
ISPN-11511/branding_banner
branch
2 times, most recently
from
026893d
to
1e70749
Compare
pruivo
approved these changes
May 6, 2020
* Introduce an infinispan.brand.version property * Align all shell tools to print the version in the same way
tristantarrant
force-pushed
the
ISPN-11511/branding_banner
branch
from
1e70749
to
262db90
Compare
|
integrated! thanks @tristantarrant ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-11511
To get consistent branding:
-Dinfinispan.brand.name="My Brand" -Dinfinispan.brand.version="8.0.0.GA" -Dinfinispan.codename="Infinispan 11.0.0.Dev03"will result in the server (and other tools) printing the following banner:
ISPN080001: My Brand 8.0.0.GA (Infinispan 11.0.0.Dev03)