ISPN-11674 RemoteCache cleanup #8216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wburns
force-pushed
the
ISPN-11674_RemoteCache_cleanup
branch
2 times, most recently
from
6722ebd
to
08fb27c
Compare
pruivo
requested changes
May 5, 2020
client/hotrod-client/src/main/java/org/infinispan/client/hotrod/RemoteCacheManager.java
Outdated
Show resolved
Hide resolved
client/hotrod-client/src/main/java/org/infinispan/client/hotrod/impl/DelegatingRemoteCache.java
Outdated
Show resolved
Hide resolved
...otrod-client/src/main/java/org/infinispan/client/hotrod/impl/InvalidatedNearRemoteCache.java
Outdated
Show resolved
Hide resolved
client/hotrod-client/src/main/java/org/infinispan/client/hotrod/impl/RemoteCacheEntrySet.java
Outdated
Show resolved
Hide resolved
client/hotrod-client/src/main/java/org/infinispan/client/hotrod/impl/RemoteCacheEntrySet.java
Outdated
Show resolved
Hide resolved
client/hotrod-client/src/test/java/org/infinispan/client/hotrod/CacheManagerNotStartedTest.java
Outdated
Show resolved
Hide resolved
client/hotrod-client/src/test/java/org/infinispan/client/hotrod/CacheManagerStoppedTest.java
Outdated
Show resolved
Hide resolved
client/hotrod-client/src/test/java/org/infinispan/client/hotrod/SecureExecTest.java
Outdated
Show resolved
Hide resolved
client/hotrod-client/src/test/java/org/infinispan/client/hotrod/retry/ReplicationRetryTest.java
Outdated
Show resolved
Hide resolved
client/hotrod-client/src/main/java/org/infinispan/client/hotrod/impl/RemoteCacheKeySet.java
Outdated
Show resolved
Hide resolved
|
compile error in CI. cc @wburns |
|
Yeah, sorry @pruivo I haven't cleaned this one up yet since your review. |
wburns
force-pushed
the
ISPN-11674_RemoteCache_cleanup
branch
from
08fb27c
to
4d15aa3
Compare
|
Okay I have addressed all the review comments and made sure it compiles. Here is to it passing CI :) |
|
@wburns can you check CI? JCache tests are failing, some of them with ps. I'll re-review the changes later :) |
pruivo
reviewed
May 13, 2020
...rc/main/java/org/infinispan/client/hotrod/impl/transaction/TransactionalRemoteCacheImpl.java
Outdated
Show resolved
Hide resolved
pruivo
reviewed
May 13, 2020
jcache/remote/src/main/java/org/infinispan/jcache/remote/RemoteCacheWrapper.java
Show resolved
Hide resolved
pruivo
reviewed
May 13, 2020
jcache/remote/src/main/java/org/infinispan/jcache/remote/RemoteCacheWithStats.java
Outdated
Show resolved
Hide resolved
wburns
force-pushed
the
ISPN-11674_RemoteCache_cleanup
branch
from
4d15aa3
to
c509698
Compare
|
Updated again :) |
|
CI seems to be okay. Just rerunning to rule out the SCRAM failure, which should be unrelated. |
pruivo
reviewed
May 14, 2020
jcache/remote/src/main/java/org/infinispan/jcache/remote/RemoteCacheWithStats.java
Outdated
Show resolved
Hide resolved
wburns
force-pushed
the
ISPN-11674_RemoteCache_cleanup
branch
from
c509698
to
e2a1cf1
Compare
|
Updated |
pruivo
approved these changes
May 14, 2020
|
integrated! thanks @wburns ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-11674
https://issues.redhat.com/browse/ISPN-11619