ISPN-11780 updating xsite docs for IRAC implementation #8289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we mention the vector clocks too? |
Can do. I wasn't sure if saying vector clocks specifically was too low level and refer to them more abstractly as "metadata" for keys. I seem to recall that being feedback from a previous review but am happy to go into more detail. |
|
The problem here is that, by just saying we are comparing site names lexicographically to resolve conflicts, it seems like our implementation is trivial, which is not the case. |
oraNod
force-pushed
the
ISPN-11780
branch
2 times, most recently
from
fb1bdfd
to
edc8eb8
Compare
pruivo
reviewed
May 15, 2020
documentation/src/main/asciidoc/topics/con_xsite_concurrent_writes.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/topics/con_xsite_concurrent_writes.adoc
Outdated
Show resolved
Hide resolved
oraNod
commented
May 15, 2020
| ==== | ||
| Prepend site names with numbers as a simple way to represent the order of | ||
| priority for resolving conflicting entries; for example, **1LON** and **2NYC**. | ||
| ==== |
There was a problem hiding this comment.
@tristantarrant How about this as a tip to assign priority to sites?
pruivo
approved these changes
May 18, 2020
|
integrated! thanks @oraNod ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-11780