ISPN-1475 - Clean up state transfer and rehashing configuration options #833
Conversation
I moved all the common state transfer settings to a separate stateTransfer element and I deprecated the old settings. I then added the chunkSize setting to the new stateTransfer element.
|
@danberindei Looking at the code... in the mean time, you probably wanna add a section in https://docs.jboss.org/author/x/OoASAQ stating the configuration changes? |
|
@danberindei Where are the corresponding xsd changes? Please note that you need to add xsd documentation too. |
| @@ -23,10 +23,17 @@ | |||
| /** | |||
| * Configures how state is retrieved when a new cache joins the cluster. Used with invalidation | |||
| * and replication clustered modes. | |||
| * @deprecated Use {@link #stateTransfer()} instead. | |||
There was a problem hiding this comment.
This goes back to what I said in the email about marshallerClass - These xBuilder classes are new in 5.1, so I don't see the new to deprecate anything. Simply map how it used to be done with 5.0 config and how this is done now in 5.1. This applies to new StateRetrievalConfigurationX classes too. I'd just get rid of them.
There was a problem hiding this comment.
I thought it would be kind of nasty to keep the old configurations right until the last CR and only remove them in the FINAL.
@maniksurtani, do you agree with removing the deprecated config directly or should I keep them?
|
@danberindei @galderz +1on catching the XSD thing. Thanks @galderz . |
|
@galderz sorry about the missing xsd + documentation, coming right up |
I updated the XSD with the new stateTransfer element.
I moved all the common state transfer settings to a separate stateTransfer
element and I deprecated the old settings.
I then added the chunkSize setting to the new stateTransfer element.