ISPN-9469 Implement timeout for queries #8382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is GREEN |
anistor
reviewed
Jun 1, 2020
| @@ -82,19 +86,15 @@ public void resetQuery() { | |||
| } else { | |||
| Comparator<Comparable<FilterResult>[]> comparator = getComparator(); | |||
| if (comparator == null) { | |||
| results = StreamSupport.stream(spliterator(), false).collect(Collectors.toList()); | |||
| results = StreamSupport.stream(spliterator(), false).collect(new TimedCollector<>(Collectors.toList(), timeout)); | |||
There was a problem hiding this comment.
So the timeout is detected when collecting. But what if the splitterator blocks indefinitely when trying to fetch next?
There was a problem hiding this comment.
It will probably timeout after the RpcTimeout
There was a problem hiding this comment.
I could also set the timeout in the stream itself, but only distributed streams support timeout
gustavocoding
force-pushed
the
ISPN-9469_query_timeout
branch
from
f0af2df
to
e597450
Compare
anistor
reviewed
Jun 2, 2020
| * | ||
| * @since 11.0 | ||
| */ | ||
| public class SearchTimeoutException extends RuntimeException { |
There was a problem hiding this comment.
I guess the days of dsl package are numbered. could we maybe move this to top level query package ?
There was a problem hiding this comment.
Ok. Now I'm going to worry about split packages :) Not sure if that is still relevant for java modules, or osgi.
gustavocoding
force-pushed
the
ISPN-9469_query_timeout
branch
from
e597450
to
5f5600c
Compare
|
Merged in master. Thanks @gustavonalle ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-9469