Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-11950 Create a new module called server-integration module into integrationtests module #8423

Merged
merged 1 commit into from Aug 25, 2020
Merged

ISPN-11950 Create a new module called server-integration module into integrationtests module #8423

merged 1 commit into from Aug 25, 2020

Conversation

gustavolira
Copy link
Contributor

ryanemerson
ryanemerson reviewed Jun 9, 2020
View reviewed changes
integrationtests/server-integration/pom.xml
<modelVersion>4.0.0</modelVersion>
<packaging>pom</packaging>

<artifactId>infinispan-server-integration</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infinispan-server-integration-parent?

gustavolira
gustavolira commented Jun 9, 2020
View reviewed changes
pom.xml Show resolved Hide resolved
@gustavolira gustavolira force-pushed the server-integration branch 3 times, most recently from e8ab6fa to 0ce80f2 Compare June 15, 2020 17:45
@gustavolira
Copy link
Contributor Author

Hey @tristantarrant can you review this PR?

@ryanemerson
Copy link
Contributor

ryanemerson commented Aug 25, 2020 •
edited

@gustavolira The build is failing as the versions of the added pom.xml files need to be updated to 12.0.0-SNAPSHOT.

@gustavolira
Copy link
Contributor Author

@gustavolira The build is failing as the versions of the added pom.xml files need to be updated to 12.0.0-SNAPSHOT.

Thanks @ryanemerson, I just fixed

@ryanemerson
Copy link
Contributor

@gustavolira The execution time of the run is way too quick, I don't think all of the tests are being executed like you expect:

14:31:46  09:31:46.193 [INFO] Infinispan WildFly Feature Pack .................... SUCCESS [  4.067 s]
14:31:46  09:31:46.193 [INFO] Infinispan Integration Tests Parent ................ SUCCESS [  0.071 s]
14:31:46  09:31:46.193 [INFO] Integration tests - Endpoints interop .............. SUCCESS [ 17.334 s]
14:31:46  09:31:46.193 [INFO] Integration tests - JBoss Marshalling interop ...... SUCCESS [  9.310 s]
14:31:46  09:31:46.194 [INFO] Integration tests - CDI/JCache interactions ........ SUCCESS [  6.585 s]
14:31:46  09:31:46.194 [INFO] Integration tests - Security Tests ................. SUCCESS [04:36 min]
14:31:46  09:31:46.194 [INFO] Integration tests - SecurityManager tests .......... SUCCESS [ 35.785 s]
14:31:46  09:31:46.194 [INFO] Integration tests - Weld SE CDI tests .............. SUCCESS [  3.599 s]
14:31:46  09:31:46.194 [INFO] Integration tests - Spring Boot .................... SUCCESS [  9.408 s]
14:31:46  09:31:46.194 [INFO] Server Integration ................................. SUCCESS [ 12.072 s]
14:31:46  09:31:46.195 [INFO] Integration tests - WildFly Module Integration Tests SUCCESS [  4.970 s]

@gustavolira
Copy link
Contributor Author

@gustavolira The execution time of the run is way too quick, I don't think all of the tests are being executed like you expect:

14:31:46  09:31:46.193 [INFO] Infinispan WildFly Feature Pack .................... SUCCESS [  4.067 s]
14:31:46  09:31:46.193 [INFO] Infinispan Integration Tests Parent ................ SUCCESS [  0.071 s]
14:31:46  09:31:46.193 [INFO] Integration tests - Endpoints interop .............. SUCCESS [ 17.334 s]
14:31:46  09:31:46.193 [INFO] Integration tests - JBoss Marshalling interop ...... SUCCESS [  9.310 s]
14:31:46  09:31:46.194 [INFO] Integration tests - CDI/JCache interactions ........ SUCCESS [  6.585 s]
14:31:46  09:31:46.194 [INFO] Integration tests - Security Tests ................. SUCCESS [04:36 min]
14:31:46  09:31:46.194 [INFO] Integration tests - SecurityManager tests .......... SUCCESS [ 35.785 s]
14:31:46  09:31:46.194 [INFO] Integration tests - Weld SE CDI tests .............. SUCCESS [  3.599 s]
14:31:46  09:31:46.194 [INFO] Integration tests - Spring Boot .................... SUCCESS [  9.408 s]
14:31:46  09:31:46.194 [INFO] Server Integration ................................. SUCCESS [ 12.072 s]
14:31:46  09:31:46.195 [INFO] Integration tests - WildFly Module Integration Tests SUCCESS [  4.970 s]

@ryanemerson good catch, I just update, thanks!

@ryanemerson ryanemerson merged commit bf4e4c7 into infinispan:master Aug 25, 2020
@ryanemerson
Copy link
Contributor

Thanks @gustavolira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanemerson ryanemerson Awaiting requested review from ryanemerson

Assignees
No one assigned
Labels
Changes Required
Projects
None yet
Milestone
No milestone
3 participants
@gustavolira @ryanemerson @tristantarrant