Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-11731 Add blockhound to query module #8613

Merged
merged 2 commits into from Aug 17, 2020

Conversation

gustavocoding
Copy link

@gustavocoding
Copy link
Author

@wburns I wonder why Blockhound does not complain about this:

results.add(await(localResponse.toCompletableFuture()));

I'd expect it to fail the tests

@wburns
Copy link
Member

wburns commented Aug 10, 2020

@wburns I wonder why Blockhound does not complain about this:

results.add(await(localResponse.toCompletableFuture()));

I'd expect it to fail the tests

My guess is maybe it is invoked on a blocking thread. I would recommend running with -Dmaven.surefire.debug on the command line and add a breakpoint to see for sure.

@gustavocoding
Copy link
Author

gustavocoding commented Aug 11, 2020

@wburns in library mode it blocks in the surefire thread while in server mode, both REST and HotRod perform queries in a separated executor. I've added a new commit to remove the 'isBlockingWrite' check from HotRod, the rest of the work to remove other blocks on query will come later

@wburns wburns merged commit 610e4e7 into infinispan:master Aug 17, 2020
@wburns
Copy link
Member

wburns commented Aug 17, 2020

Integrated into master, thanks @gustavonalle !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants