Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-12173 update eviction description #8617

Merged
merged 1 commit into from Aug 19, 2020

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Aug 11, 2020

@oraNod oraNod requested a review from wburns August 11, 2020 13:58
@oraNod oraNod added Documentation Pull request containing only documentation changes Trivial :-) labels Aug 11, 2020
ensure that entries remain available after {brandname} evicts them, you should
configure a persistent cache store.
ensure that entries remain available after {brandname} evicts them, and to
prevent inconsistencies with your data, you should configure a persistent cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make is stronger
maybe "strongly recommeded" ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure about saying "strongly recommend". This text is in an important note so I think it has sufficient emphasis.

@ryanemerson ryanemerson merged commit 36e73e4 into infinispan:master Aug 19, 2020
@ryanemerson
Copy link
Contributor

ryanemerson commented Aug 19, 2020

Thanks @oraNod. Leaving the Jira open until the backport is up

@oraNod oraNod deleted the ISPN-12173 branch January 24, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Pull request containing only documentation changes Trivial :-)
Projects
None yet
3 participants