Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-12217 Adding detail about ports and protocols #8618

Merged
merged 1 commit into from Aug 25, 2020
Merged

ISPN-12217 Adding detail about ports and protocols #8618

merged 1 commit into from Aug 25, 2020

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Aug 11, 2020

@oraNod oraNod added the Documentation Pull request containing only documentation changes label Aug 11, 2020
@oraNod oraNod requested a review from belaban August 11, 2020 15:28
@belaban
Copy link
Member

belaban commented Aug 11, 2020

The ports for UDP and TCP are correct, according to default-jgroups-udp.xml and default-jgroups-tcp.xml (Infinispan/core/src/resources)

@oraNod
Copy link
Contributor Author

oraNod commented Aug 11, 2020

The ports for UDP and TCP are correct, according to default-jgroups-udp.xml and default-jgroups-tcp.xml (Infinispan/core/src/resources)

@belaban thanks. I wasn't sure about UDP based on https://github.com/infinispan/infinispan/blob/master/core/src/main/resources/default-configs/default-jgroups-udp.xml#L5 - do you know if this inherits the bind port from the TCP config or something like that?

belaban
belaban approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@belaban belaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@belaban
Copy link
Member

belaban commented Aug 11, 2020

No, bind_port is randomly picked. What's set here is mcast_port.

danberindei
danberindei reviewed Aug 19, 2020
View reviewed changes
documentation/src/main/asciidoc/topics/ref_ports_protocols.adoc Outdated Show resolved Hide resolved
documentation/src/main/asciidoc/topics/ref_ports_protocols.adoc Outdated
|TCP
|Hot Rod and REST endpoint access

|11221
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tristantarrant do you remember how we ended up using 11221 as the default memcached port? In the WildFly-based server it used to be 11211 (Memcached's default):
https://github.com/infinispan/infinispan/blob/9.4.x/server/integration/endpoint/src/main/resources/subsystem-templates/infinispan-endpoint.xml#L166

documentation/src/main/asciidoc/topics/ref_ports_protocols.adoc Outdated Show resolved Hide resolved
@oraNod oraNod changed the title ISPN-12217 ports and protocols ISPN-12217 Adding detail about ports and protocols Aug 21, 2020
@tristantarrant tristantarrant merged commit baae222 into infinispan:master Aug 25, 2020
@tristantarrant
Copy link
Member

Merged

@tristantarrant
Copy link
Member

I'll handle the backport

@oraNod oraNod deleted the ISPN-12217 branch January 24, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belaban belaban belaban approved these changes

@diegolovison diegolovison Awaiting requested review from diegolovison

@wburns wburns Awaiting requested review from wburns

@danberindei danberindei Awaiting requested review from danberindei

@tristantarrant tristantarrant Awaiting requested review from tristantarrant

Assignees
No one assigned
Labels
Documentation Pull request containing only documentation changes
Projects
None yet
Milestone
No milestone
4 participants
@oraNod @belaban @tristantarrant @danberindei