Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-12204 Add JDBC Meta Table #8620

Merged
merged 1 commit into from Sep 4, 2020
Merged

ISPN-12204 Add JDBC Meta Table #8620

merged 1 commit into from Sep 4, 2020

Conversation

ryanemerson
Copy link
Contributor

@ryanemerson ryanemerson force-pushed the ISPN-12204 branch 2 times, most recently from 8e0ae5e to 50ed3e3 Compare August 13, 2020 13:09
@ryanemerson ryanemerson force-pushed the ISPN-12204 branch 3 times, most recently from f1fcab6 to df32cee Compare August 18, 2020 12:27
wburns
wburns reviewed Aug 21, 2020
View reviewed changes
Copy link
Member

@wburns wburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should probably just add a blurb about this table in the documentation. Upgrading and user guide. We don't want someone deleting this table :)

@ryanemerson
Copy link
Contributor Author

@wburns Good thinking. I've added some info to the upgrading guide and the docs.

@wburns
Copy link
Member

wburns commented Sep 4, 2020

LGTM, will press button after CI confirms.

@wburns wburns merged commit a47bdad into infinispan:master Sep 4, 2020
@wburns
Copy link
Member

wburns commented Sep 4, 2020

Integrated into master, thanks @ryanemerson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wburns wburns wburns left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ryanemerson @wburns @gustavocoding