ISPN-12205 Add RocksDB Meta Column Family #8629
Conversation
|
|
||
| MetadataImpl existingMeta = handler.loadMetadata(); | ||
| if (existingMeta != null) { | ||
| // TODO Perform validation/migration |
There was a problem hiding this comment.
Maybe for this iteration we can just verify the version and if there is a mismatch log a WARN/INFO message?
There was a problem hiding this comment.
Tbh as this is the first version that has this logic, I'm not sure how there could be a mismatch. It's also possible (in fact desirable) in future versions that loading from a previous major should not require migration, so logging would only add noise IMO.
| // TODO Perform validation/migration | ||
| } | ||
| // Update the metadata entry to use the current Infinispan version | ||
| handler.writeMetadata(); |
There was a problem hiding this comment.
I am not sure we want to do this if the versions don't match.
There was a problem hiding this comment.
My plan was that if there are any incompatibilies they will be handled via the migration logic between x and latest version, or if this is not possible an exception is thrown before this statement is reached.
There was a problem hiding this comment.
Oh I agree. I am more saying in case we never get this completed. I know how some features have ideas for the future but it never comes to fruition.
There was a problem hiding this comment.
Ok. I've added a variable to prevent this in the meantime.
ryanemerson
force-pushed
the
ISPN-12205
branch
from
aa63889
to
f37550c
Compare
ryanemerson
force-pushed
the
ISPN-12205
branch
from
f37550c
to
f6bee24
Compare
|
LGTM, will press button after CI confirms. |
|
Integrated into master, thanks @ryanemerson ! |
https://issues.redhat.com/browse/ISPN-12205