ISPN-6901 ConsistentHashV2IntegrationTest.testCorrectBalancingOfKeysAfterNodeKill fails #8645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danberindei
force-pushed
the
ISPN-6901_ConsistentHashV2IntegrationTest.testCorrectBalancingOfKeysAfterNodeKill_m
branch
from
3bc894a
to
8b74b83
Compare
karesti
requested changes
Sep 3, 2020
| @@ -147,7 +146,7 @@ public void testCorrectBalancingOfKeysAfterNodeKill() { | |||
| log.tracef("Client topology id is %d, waiting for it to become %d", topologyId, | |||
| topologyIdBeforeJoin + 2); | |||
| // The put operation will update the client topology (if necessary) | |||
There was a problem hiding this comment.
comment should be removed I think
There was a problem hiding this comment.
@karesti I replaced put with get, sorry for the oversight.
…fterNodeKill fails Re-enable test
danberindei
force-pushed
the
ISPN-6901_ConsistentHashV2IntegrationTest.testCorrectBalancingOfKeysAfterNodeKill_m
branch
from
8b74b83
to
9557ce1
Compare
danberindei
deleted the
ISPN-6901_ConsistentHashV2IntegrationTest.testCorrectBalancingOfKeysAfterNodeKill_m
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-6901
https://issues.redhat.com/browse/ISPN-12254
I was not able to reproduce the failure, so I'm re-enabling the test.
I did find a NPE in CheckAddressTask, but it's just a cosmetic issue.