Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-12314 lsof check is too expensive #8679

Merged
merged 1 commit into from Sep 12, 2020
Merged

ISPN-12314 lsof check is too expensive #8679

merged 1 commit into from Sep 12, 2020

Conversation

danberindei
Copy link
Member

https://issues.redhat.com/browse/ISPN-12314

  • Run lsof a single time, fail the build if it does not exist
  • Remove the ps and jps checks

@danberindei
ISPN-12314 lsof check is too expensive
3d38238 
* Run lsof a single time, fail the build if it does not exist
* Remove the ps and jps checks
@diegolovison
Copy link
Contributor

Please, wait my bless

@diegolovison
Copy link
Contributor

It is working in RHEL7 and RHEL8.
Here are my 5 cents:

RHEL7 has lsof in the path: /usr/sbin/lsof
RHEL8 has lsof in the path: /usr/bin/lsof

Once you have the setup working, IMHO, I do prefer to have lsof instead of ps and jps.
lsof can require some local configuration but once we have it working, it will be easy to find out the root cause because we look only for the port number.
The port numbers change at a lower frequency when compared with PID searched with some pattern.

+1 to merge

@karesti karesti merged commit fad9257 into infinispan:master Sep 12, 2020
@danberindei danberindei deleted the ISPN-12314_lsof branch September 14, 2020 09:35
@danberindei danberindei mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karesti karesti karesti approved these changes

Assignees
No one assigned
Labels
Trivial :-)
Projects
None yet
Milestone
No milestone
3 participants
@danberindei @diegolovison @karesti