Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-12316 Convert expiration to no longer use transactions #8683

Merged
merged 1 commit into from Sep 10, 2020
Merged

ISPN-12316 Convert expiration to no longer use transactions #8683

merged 1 commit into from Sep 10, 2020

Conversation

wburns
Copy link
Member

@wburns wburns commented Sep 10, 2020

@wburns wburns requested a review from pruivo September 10, 2020 14:01
pruivo
pruivo requested changes Sep 10, 2020
View reviewed changes
Copy link
Member

@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about TxPutFromLoadInterceptor? I think it needs to overwrite visitRemoveExpiredCommand otherwise it tries to interact with the tx using visitRemoveCommand.

...rc/main/java/org/infinispan/interceptors/impl/TransactionalExceptionEvictionInterceptor.java Outdated Show resolved Hide resolved
...rc/main/java/org/infinispan/interceptors/impl/TransactionalExceptionEvictionInterceptor.java Outdated Show resolved Hide resolved
@wburns
Copy link
Member Author

wburns commented Sep 10, 2020

what about TxPutFromLoadInterceptor? I think it needs to overwrite visitRemoveExpiredCommand otherwise it tries to interact with the tx using visitRemoveCommand.

I guess we don't have any hibernate expiration tests :D

@wburns
Copy link
Member Author

wburns commented Sep 10, 2020

Actually I am not sure if we need to change TxPutFromLoadInterceptor, I will look a bit closer.

@wburns
Copy link
Member Author

wburns commented Sep 10, 2020 •
edited

Updated per comments.
I can rebase before merge if okay.

pruivo
pruivo approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. waiting for CI

@wburns
Copy link
Member Author

wburns commented Sep 10, 2020

Squashed commits together.

@pruivo pruivo merged commit 2a81e01 into infinispan:master Sep 10, 2020
@pruivo
Copy link
Member

pruivo commented Sep 10, 2020

failures not related. integrated! thanks @wburns !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruivo pruivo pruivo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wburns @pruivo