Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-12319 XSite Response should allow a value #8687

Merged
merged 1 commit into from Sep 15, 2020
Merged

ISPN-12319 XSite Response should allow a value #8687

merged 1 commit into from Sep 15, 2020

Conversation

wburns
Copy link
Member

@wburns wburns commented Sep 11, 2020

@wburns wburns requested a review from pruivo September 11, 2020 15:36
@wburns
Copy link
Member Author

wburns commented Sep 14, 2020

@pruivo Should be all fixed up now, thanks!

pruivo
pruivo reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor thing.

core/src/main/java/org/infinispan/xsite/SingleXSiteRpcCommand.java Outdated Show resolved Hide resolved
core/src/main/java/org/infinispan/xsite/SingleXSiteRpcCommand.java Show resolved Hide resolved
core/src/test/java/org/infinispan/jmx/PerCacheInboundHandlerMBeanTest.java Outdated Show resolved Hide resolved
@wburns
Copy link
Member Author

wburns commented Sep 14, 2020

@pruivo Made changes as suggested.

@pruivo pruivo merged commit 3305fbd into infinispan:master Sep 15, 2020
@pruivo
Copy link
Member

pruivo commented Sep 15, 2020

integrated! thanks @wburns !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruivo pruivo pruivo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wburns @pruivo