Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-6901 ConsistentHashV2IntegrationTest.testCorrectBalancingOfKeysA… #8696

Conversation

danberindei
Copy link
Member

https://issues.redhat.com/browse/ISPN-6901

Wait for number of servers in topology instead of topology id

Looks like the test started failing when we moved from 2-phase rebalancing to 4-phase rebalancing.

@wburns
Copy link
Member

wburns commented Sep 24, 2020

Changes seem fine to me from the description, however there are a bunch of leaked threads in the test suite now.

…fterNodeKill

Wait for number of servers in topology instead of topology id
@danberindei danberindei force-pushed the ISPN-6901_ConsistentHashV2IntegrationTest_still_fails branch from 5c52f21 to e9d3333 Compare September 28, 2020 18:15
@danberindei
Copy link
Member Author

@wburns somehow I managed to move the hotRodServerX = null lines from the teardown to the setup method, and then of course the cleanup method didn't have anything to clean up. It should be fixed now.

@wburns wburns merged commit eaa16f5 into infinispan:master Sep 28, 2020
@wburns
Copy link
Member

wburns commented Sep 28, 2020

Integrated into master, thanks @danberindei !

@danberindei danberindei deleted the ISPN-6901_ConsistentHashV2IntegrationTest_still_fails branch September 30, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants