ISPN-8241 Refactor RocksDB clearThreshold #8766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diegolovison Maybe we should log a separate issue instead of commenting on that issue, wdyt? |
diegolovison
force-pushed
the
ISPN-8241
branch
from
96d3ee1
to
91ae9d6
Compare
wburns
reviewed
Oct 13, 2020
persistence/rocksdb/src/main/java/org/infinispan/persistence/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
diegolovison
force-pushed
the
ISPN-8241
branch
2 times, most recently
from
b34db95
to
b3f7a17
Compare
danberindei
reviewed
Oct 21, 2020
persistence/rocksdb/src/main/java/org/infinispan/persistence/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
wburns
requested changes
Oct 21, 2020
There was a problem hiding this comment.
We also probably want to deprecate the configuration builder and the xml variable, which includes changing the parser to ignore the value and throw the error if it is supplied in 12.0+
Also we should probably add a comment to the upgrading guide and remove from the configuration option from the user guide.
persistence/rocksdb/src/main/java/org/infinispan/persistence/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
persistence/rocksdb/src/test/java/org/infinispan/persistence/rocksdb/RocksDBStoreTest.java
Outdated
Show resolved
Hide resolved
persistence/rocksdb/src/test/java/org/infinispan/persistence/rocksdb/RocksDBStoreTest.java
Outdated
Show resolved
Hide resolved
danberindei
suggested changes
Oct 22, 2020
There was a problem hiding this comment.
I have a few more comments, Diego.
Here's what I would change: master...danberindei:dan_ISPN-8241_RocksDBStore
persistence/rocksdb/src/main/java/org/infinispan/persistence/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
persistence/rocksdb/src/main/java/org/infinispan/persistence/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
persistence/rocksdb/src/test/java/org/infinispan/persistence/rocksdb/RocksDBStoreTest.java
Outdated
Show resolved
Hide resolved
persistence/rocksdb/src/test/java/org/infinispan/persistence/rocksdb/RocksDBStoreTest.java
Outdated
Show resolved
Hide resolved
persistence/rocksdb/src/test/java/org/infinispan/persistence/rocksdb/RocksDBStoreTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/infinispan/persistence/rocksdb/configuration/RocksDBStoreConfiguration.java
Show resolved
Hide resolved
diegolovison
force-pushed
the
ISPN-8241
branch
from
b3f7a17
to
c1f637a
Compare
RocksDBStore now uses DeleteRange to clear the database or a column family.
diegolovison
force-pushed
the
ISPN-8241
branch
from
c1f637a
to
0359a01
Compare
|
Integrated, thanks Diego! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-8241