ISPN-12101 Credential Store #8841

tristantarrant · 2020-11-10T14:00:35Z

https://issues.redhat.com/browse/ISPN-12101

tristantarrant · 2020-11-10T14:06:49Z

@oraNod some docs in here that will probably need your expertise

tristantarrant · 2020-11-10T14:08:14Z

oops, I think I may have messed up with the SSL docs. I'll fix that.

pruivo · 2020-11-11T11:22:34Z

@tristantarrant is this PR completed? A quick look shows CredentialStoresConfiguration is empty and I don't see where it is used. what am I missing?

tristantarrant · 2020-11-11T11:59:48Z

The only purpose for that is for the Json configuration serialization

pruivo

partial look #1 :)

cli/src/main/java/org/infinispan/cli/commands/Credentials.java

cli/src/main/resources/help/credentials.adoc

documentation/src/main/asciidoc/stories/assembly_server_security_credentials.adoc

...er/runtime/src/main/java/org/infinispan/server/configuration/ServerConfigurationBuilder.java

tristantarrant · 2020-11-11T13:18:26Z

@diegolovison can you look at the tests

server/runtime/src/main/java/org/infinispan/server/configuration/ServerConfigurationParser.java

...src/main/java/org/infinispan/server/configuration/security/CredentialStoreConfiguration.java

...n/java/org/infinispan/server/configuration/security/CredentialStoreConfigurationBuilder.java

.../java/org/infinispan/server/configuration/security/CredentialStoresConfigurationBuilder.java

server/runtime/src/main/resources/schema/infinispan-server-12.0.xsd

server/runtime/src/main/server/server/conf/infinispan.xml

server/runtime/src/test/resources/configuration/ServerConfigurationParserTest.xml

documentation/src/main/asciidoc/topics/cmd_examples/credentials_nix.adoc

documentation/src/main/asciidoc/topics/cmd_examples/credentials_win.adoc

pruivo · 2020-11-11T15:55:15Z

@tristantarrant the CLI creates the keystore in $PWD and not in server/conf by default. can't be changed?

[pedro@pedro-desktop infinispan-server-12.0.0-SNAPSHOT]$ ./bin/cli.sh credentials add dbpassword -p "secret1234!"
Set a credential: 
Confirm the credential: 
[pedro@pedro-desktop infinispan-server-12.0.0-SNAPSHOT]$ ls
bin  boot  Copyright.txt  credentials.pfx  docs  lib  README.md  server  static

tristantarrant · 2020-11-11T15:59:37Z

Working on that

pruivo

offtopic change if possible:
org.infinispan.server.configuration.ServerConfigurationParser#coreLog field can be final

cli/src/main/java/org/infinispan/cli/commands/Credentials.java

cli/src/main/resources/help/credentials.adoc

...e/src/main/java/org/infinispan/server/configuration/security/RealmsConfigurationBuilder.java

...untime/src/main/java/org/infinispan/server/configuration/security/SecurityConfiguration.java

...src/main/java/org/infinispan/server/configuration/security/SecurityConfigurationBuilder.java

...runtime/src/test/java/org/infinispan/server/configuration/ServerConfigurationParserTest.java

server/runtime/src/main/resources/schema/infinispan-server-12.0.xsd

server/runtime/src/main/server/server/conf/infinispan.xml

documentation/src/main/asciidoc/topics/proc_server_credentials.adoc

tristantarrant · 2020-11-24T13:57:00Z

@pruivo addressed all comments and repushed

pruivo · 2020-11-24T13:58:45Z

what about the hidden comments? :)

tristantarrant · 2020-11-24T14:06:09Z

Damn, now it's done

cli/src/main/resources/help/credentials.adoc

pruivo · 2020-11-24T15:16:35Z

...src/main/java/org/infinispan/server/configuration/security/CredentialStoreConfiguration.java

+      return new AttributeSet(CredentialStoreConfiguration.class, NAME, PATH, RELATIVE_TO, TYPE, CREDENTIAL);
+   }
+
+   private static ElementDefinition<CredentialStoreConfiguration> ELEMENT_DEFINITION = new DefaultElementDefinition(Element.CREDENTIAL_STORE.toString());


this was partially applied :)

pruivo · 2020-11-24T15:18:01Z

...rc/main/java/org/infinispan/server/configuration/security/CredentialStoresConfiguration.java

+ * @since 12.0
+ **/
+public class CredentialStoresConfiguration implements ConfigurationInfo {
+   private static final ElementDefinition<CredentialStoresConfiguration> ELEMENT_DEFINITION = new DefaultElementDefinition(Element.CREDENTIAL_STORES.toString());


change not applied.

pruivo · 2020-11-24T15:18:26Z

...rc/main/java/org/infinispan/server/configuration/security/CredentialStoresConfiguration.java

+public class CredentialStoresConfiguration implements ConfigurationInfo {
+   private static final ElementDefinition<CredentialStoresConfiguration> ELEMENT_DEFINITION = new DefaultElementDefinition(Element.CREDENTIAL_STORES.toString());
+
+   private final List<CredentialStoreConfiguration> credentialStores;


can be removed :)

...untime/src/main/java/org/infinispan/server/configuration/security/SecurityConfiguration.java

...runtime/src/test/java/org/infinispan/server/configuration/ServerConfigurationParserTest.java

...n/java/org/infinispan/server/configuration/security/CredentialStoreConfigurationBuilder.java

tristantarrant · 2020-11-25T07:54:21Z

@pruivo The CLI now behaves as follows:
if the argument to path is plain (i.e. just the filename), then it is relative to $ISPN_ROOT/conf. Otherwise it will be relative to cwd or absolute (if it starts with a /)

pruivo

final nitpicks. I would have merged it but I've noticed the formatting error in "help" message; so I added the other 2 nits :)

cli/src/main/resources/help/credentials.adoc

...n/java/org/infinispan/server/configuration/security/CredentialStoreConfigurationBuilder.java

...src/main/java/org/infinispan/server/configuration/security/CredentialStoreConfiguration.java

tristantarrant · 2020-11-25T11:11:36Z

@pruivo done

pruivo · 2020-11-25T13:18:33Z

integrated! thanks @tristantarrant !

tristantarrant force-pushed the ISPN-12101/credential-store branch 3 times, most recently from f4d0e1e to e6cc584 Compare November 10, 2020 14:12

oraNod added the Documentation Pull request containing only documentation changes label Nov 10, 2020

pruivo requested changes Nov 11, 2020

View reviewed changes

documentation/src/main/asciidoc/topics/cmd_examples/credentials_nix.adoc Outdated Show resolved Hide resolved

documentation/src/main/asciidoc/topics/cmd_examples/credentials_win.adoc Outdated Show resolved Hide resolved

tristantarrant force-pushed the ISPN-12101/credential-store branch 3 times, most recently from e47086a to 2c37a37 Compare November 13, 2020 07:46

pruivo requested changes Nov 13, 2020

View reviewed changes

oraNod reviewed Nov 13, 2020

View reviewed changes

server/runtime/src/main/server/server/conf/infinispan.xml Show resolved Hide resolved

pruivo reviewed Nov 19, 2020

View reviewed changes

documentation/src/main/asciidoc/topics/proc_server_credentials.adoc Outdated Show resolved Hide resolved

tristantarrant force-pushed the ISPN-12101/credential-store branch from 768ffe1 to 233e3ee Compare November 24, 2020 13:47

tristantarrant removed the Documentation Pull request containing only documentation changes label Nov 24, 2020

tristantarrant force-pushed the ISPN-12101/credential-store branch from 233e3ee to 30c99ab Compare November 24, 2020 13:56

tristantarrant force-pushed the ISPN-12101/credential-store branch 2 times, most recently from 083c708 to e608605 Compare November 24, 2020 14:05

pruivo reviewed Nov 24, 2020

View reviewed changes

tristantarrant force-pushed the ISPN-12101/credential-store branch from e608605 to f1872f2 Compare November 24, 2020 17:54

tristantarrant force-pushed the ISPN-12101/credential-store branch from f1872f2 to fbe9985 Compare November 24, 2020 20:37

pruivo reviewed Nov 25, 2020

View reviewed changes

ISPN-12101 Credential Store

e2d8419

tristantarrant force-pushed the ISPN-12101/credential-store branch from dd3f573 to e2d8419 Compare November 25, 2020 11:11

pruivo approved these changes Nov 25, 2020

View reviewed changes

pruivo merged commit 507a6ab into infinispan:master Nov 25, 2020

tristantarrant deleted the ISPN-12101/credential-store branch July 5, 2022 09:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ISPN-12101 Credential Store #8841

ISPN-12101 Credential Store #8841

tristantarrant commented Nov 10, 2020

tristantarrant commented Nov 10, 2020

tristantarrant commented Nov 10, 2020

pruivo commented Nov 11, 2020

tristantarrant commented Nov 11, 2020

pruivo left a comment

tristantarrant commented Nov 11, 2020

pruivo commented Nov 11, 2020

tristantarrant commented Nov 11, 2020

pruivo left a comment

tristantarrant commented Nov 24, 2020

pruivo commented Nov 24, 2020

tristantarrant commented Nov 24, 2020

pruivo Nov 24, 2020

pruivo Nov 24, 2020

pruivo Nov 24, 2020

tristantarrant commented Nov 25, 2020

pruivo left a comment

tristantarrant commented Nov 25, 2020

pruivo commented Nov 25, 2020

ISPN-12101 Credential Store #8841

ISPN-12101 Credential Store #8841

Conversation

tristantarrant commented Nov 10, 2020

tristantarrant commented Nov 10, 2020

tristantarrant commented Nov 10, 2020

pruivo commented Nov 11, 2020

tristantarrant commented Nov 11, 2020

pruivo left a comment

Choose a reason for hiding this comment

tristantarrant commented Nov 11, 2020

pruivo commented Nov 11, 2020

tristantarrant commented Nov 11, 2020

pruivo left a comment

Choose a reason for hiding this comment

tristantarrant commented Nov 24, 2020

pruivo commented Nov 24, 2020

tristantarrant commented Nov 24, 2020

pruivo Nov 24, 2020

Choose a reason for hiding this comment

pruivo Nov 24, 2020

Choose a reason for hiding this comment

pruivo Nov 24, 2020

Choose a reason for hiding this comment

tristantarrant commented Nov 25, 2020

pruivo left a comment

Choose a reason for hiding this comment

tristantarrant commented Nov 25, 2020

pruivo commented Nov 25, 2020