ISPN-12565 Converts lifespan and maxidle to seconds #8924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wburns
reviewed
Dec 10, 2020
server/rest/src/main/java/org/infinispan/rest/CacheEntryInputStream.java
Outdated
Show resolved
Hide resolved
|
@wburns if CI is ok wtyt |
|
Changes look good to me. The only question I have is if this is safe to change the returned json? This is only used as of 12.0? |
wburns
approved these changes
Dec 14, 2020
|
@wburns yes, this was introduced in 12 |
|
Integrated into master, thanks @karesti ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-12565