ISPN-12667 GlobalState incompatibility between 11.x and 12.x #9019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pruivo
requested changes
Jan 29, 2021
core/src/main/java/org/infinispan/distribution/ch/impl/ReplicatedConsistentHash.java
Outdated
Show resolved
Hide resolved
| * @author Ryan Emerson | ||
| * @since 12.0 | ||
| */ | ||
| public class GlobalStateBackwardsCompatibilityTest extends MultipleCacheManagersTest { |
There was a problem hiding this comment.
The test isn't running.
Suggested change
| public class GlobalStateBackwardsCompatibilityTest extends MultipleCacheManagersTest { | |
| @Test(groups = "functional", testName = "globalstate.GlobalStateBackwardsCompatibilityTest") | |
| public class GlobalStateBackwardsCompatibilityTest extends MultipleCacheManagersTest { |
There was a problem hiding this comment.
I swear I forgot the @Test annotation every time! Or copy and paste and forget to update the testName 🤕
core/src/test/java/org/infinispan/globalstate/GlobalStateBackwardsCompatibilityTest.java
Show resolved
Hide resolved
ryanemerson
force-pushed
the
ISPN-12667
branch
from
31cf42b
to
e30bfb4
Compare
pruivo
approved these changes
Jan 29, 2021
|
integrated! thanks @ryanemerson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-12667
Backport: #9020