ISPN-12548 Replicated cache get ignores value in zero-capacity nodes #9024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not use GetReplCache on zero-capacity nodes * Extend ClusteredLockWithZeroCapacityNodesTest * Remove REPL_SYNC references in clustered locks tests * Make waitForNoRebalance work with zero-capacity nodes
* Split TestFunctionalWriteOperation from TestWriteOperation. * Make operation REPLACE_META_FUNCTIONAL work outside NonTxBackupOwnerBecomingPrimaryOwnerTest. * Extend ZeroCapacityNodeTest to run all functional and non-functional write operations.
…d caches * Keep broadcasting single-key commands to all the members, but to not wrap any key and do not perform the write. * Since many-key commands use unicasts, don't send them to zero-capacity nodes at all.
ryanemerson
reviewed
Feb 3, 2021
There was a problem hiding this comment.
LGTM, just one minor nitpick. @danberindei Can you backport to 12.0.x so that we can get this in the operator?
| * Represents a functional write operation to test. | ||
| * | ||
| * @author Dan Berindei | ||
| * @since 12.0 |
There was a problem hiding this comment.
@ryanemerson if I backport it to 12.0.1, then wouldn't the @since 12.0 tag be correct? :)
|
@ryanemerson backport open: #9034 |
|
Thanks @danberindei |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ISPN-12662 Extend zero-capacity node testing in core
https://issues.redhat.com/browse/ISPN-12548
https://issues.redhat.com/browse/ISPN-12662
Do not use GetReplCache on zero-capacity nodes
Extend ClusteredLockWithZeroCapacityNodesTest
Remove REPL_SYNC references in clustered locks tests
Make waitForNoRebalance work with zero-capacity nodes
Split TestFunctionalWriteOperation from TestWriteOperation.
Make operation REPLACE_META_FUNCTIONAL work outside
NonTxBackupOwnerBecomingPrimaryOwnerTest.
Extend ZeroCapacityNodeTest to run all functional and non-functional
write operations.
Keep broadcasting single-key commands to all the members,
but to not wrap any key and do not perform the write.
Since many-key commands use unicasts, don't send them to
zero-capacity nodes at all.