ISPN-12646 IllegalArgumentException when doing Rolling Upgrades on transactional caches #9033
Conversation
|
Failures unrelated |
|
Merged from other PR |
|
@tristantarrant The other PR didn't have all the commits from this one, I will rebase |
|
oops |
gustavocoding
force-pushed
the
ISPN-12646_rolling_upgrade_tx_master
branch
from
80393ac
to
809f2ff
Compare
|
should be ready to merge @tristantarrant |
| Integer DISCONNECT_REMOTE_STORE = 1902; | ||
|
|
||
| Integer ENTRY_WRITER = 1902; | ||
| Integer DISCONNECT_REMOTE_STORE = 1903; |
There was a problem hiding this comment.
why increasing the DISCONNECT_REMOTE_STORE id? couldn't ENTRY_WRITER be 1093?
There was a problem hiding this comment.
No reason, it was a merge issue, let me put it back
…ansactional caches
gustavocoding
force-pushed
the
ISPN-12646_rolling_upgrade_tx_master
branch
from
809f2ff
to
140929d
Compare
| @@ -102,6 +103,9 @@ private boolean skewed(IncrementableEntryVersion prevVersion, EntryVersion versi | |||
| } | |||
| IncrementableEntryVersion prevVersion = versionFromEntry(ice); | |||
| if (prevVersion == null) { | |||
| if (rollingUpgrade) { | |||
| return versionGenerator.nonExistingVersion(); | |||
There was a problem hiding this comment.
Wouldn't it be better to return nonExistingVersion() every time, without adding the rollingUpgrade parameter?
There was a problem hiding this comment.
I'm not sure, wdyt @pruivo ?
There was a problem hiding this comment.
we never have prevVersion==null except for the rolling upgrade scenario.
Hot Rod isn't aware of the internal version and Infinispan stores the entry from RemoteStore as is.
I would leave the exception there at least to make sure there are no errors.
|
integrated! thanks @gustavonalle ! |
https://issues.redhat.com/browse/ISPN-12646
Forward port from #9007