ISPN-12725 Conflict resolution fails in transactional cache with auto-commit disabled #9051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pruivo
approved these changes
Feb 11, 2021
|
@pruivo updated to include the IllegalArgumentException fix |
danberindei
changed the title
danberindei
force-pushed
the
ISPN-12715_conflict_resolution_logging
branch
3 times, most recently
from
caee5c5
to
9ab1f92
Compare
|
Updated to fix the test failures (sometimes the transaction manager is null) and to rebase on master. |
ryanemerson
reviewed
Feb 18, 2021
| * | ||
| * @author Ryan Emerson | ||
| * @since 9.1 | ||
| */ |
There was a problem hiding this comment.
I think this needs updating or removed 🙂
ryanemerson
approved these changes
Feb 18, 2021
* Log only one message, at error level * Fix other ComponentRef.getName() references
The entry returned by AdvancedCache.getCacheEntry(key) is not always an InternalCacheEntry.
danberindei
force-pushed
the
ISPN-12715_conflict_resolution_logging
branch
from
9ab1f92
to
b250163
Compare
|
Thanks @danberindei |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-12725
https://issues.redhat.com/browse/ISPN-12715
https://issues.redhat.com/browse/ISPN-12717
ISPN-12725 Conflict resolution fails in transactional cache with auto-commit disabled
ISPN-12715 Conflict resolution failure logged at debug level
ISPN-12717 DefaultConflictManager.getAllVersions fails in tx caches