ISPN-12801 Hot Rod client logs a timeout error after every server error #9097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wburns
reviewed
Mar 10, 2021
...otrod-client/src/main/java/org/infinispan/client/hotrod/impl/operations/HotRodOperation.java
Outdated
Show resolved
Hide resolved
client/hotrod-client/src/test/java/org/infinispan/client/hotrod/admin/RemoteCacheAdminTest.java
Outdated
Show resolved
Hide resolved
| @@ -68,4 +70,20 @@ protected void executeOperation(Channel channel) { | |||
| public void acceptResponse(ByteBuf buf, short status, HeaderDecoder decoder) { | |||
| complete(bytes2obj(channelFactory.getMarshaller(), ByteBufUtil.readArray(buf), dataFormat.isObjectStorage(), cfg.getClassAllowList())); | |||
| } | |||
|
|
|||
| @Override | |||
| protected void addParams(StringBuilder sb) { | |||
There was a problem hiding this comment.
This seems a bit unrelated, but fine
There was a problem hiding this comment.
Without this change, cache creation operations are logged as AdminOperation (default), with no mention of the cache name.
danberindei
force-pushed
the
ISPN-12801_hotrod_client_timeout
branch
from
ec5127c
to
295c15b
Compare
danberindei
force-pushed
the
ISPN-12801_hotrod_client_timeout
branch
from
295c15b
to
00f6ae1
Compare
* Extract timeout task cancellation to a new method * Add a test for cache creation failure. * Add scheduled task check in ServerErrorTest * Improve logging for admin and execute operations.
danberindei
force-pushed
the
ISPN-12801_hotrod_client_timeout
branch
from
00f6ae1
to
67928d5
Compare
|
Integrated into master, thanks @danberindei ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-12801