ISPN-128806 BlockingManagerImpl#thenRunBlocking doesn't join #9100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pruivo
reviewed
Mar 5, 2021
| @@ -197,6 +197,7 @@ public void execute(Runnable command) { | |||
| log.tracef("Invoked thenRun on a blocking thread, joining %s in same blocking thread", traceId); | |||
| } | |||
| try { | |||
| CompletionStages.join(stage); | |||
| return stage.thenRun(runnable); | |||
There was a problem hiding this comment.
it isn't trivial for me xD
Why do you need stage.thenRun(runnable)?
Could you just invoke runnable.run() and return CompletableFutures.completedNull()?
There was a problem hiding this comment.
Sure, either way would work. The point is the stage needs to be complete. I can change it to that if you want.
There was a problem hiding this comment.
I would say to invoke the Runnable directly.
java.util.concurrent.CompletableFuture#thenRun() seems to create a new CompletableFuture instance.
There was a problem hiding this comment.
Yep, I already pushed the change. 👍
wburns
force-pushed
the
ISPN-12806_BlockingManager_thenRunBlocking
branch
from
e0b75e6
to
cd2f763
Compare
pruivo
approved these changes
Mar 5, 2021
|
Thanks @wburns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-12806