ISPN-4996 Problem with capacityFactor=0 and restart of all regular nodes #9161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danberindei
force-pushed
the
ISPN-4996_zero_capacity_node
branch
from
214fec0
to
8b4b839
Compare
ryanemerson
reviewed
Mar 24, 2021
core/src/main/java/org/infinispan/topology/ClusterCacheStatus.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/infinispan/distribution/ZeroCapacityNodeTest.java
Outdated
Show resolved
Hide resolved
| Future<Cache<Object, Object>> node1Future = | ||
| fork(() -> node1.createCache(cacheName, cbZero.build())); | ||
|
|
||
| TestingUtil.sleepThread(10); |
There was a problem hiding this comment.
Can we not make use of the TimeService here to avoid waiting for 10 seconds?
There was a problem hiding this comment.
The wait is just 10ms, not 10s, but I'll give it a try.
There was a problem hiding this comment.
Updated to remove the sleep
There was a problem hiding this comment.
The wait is just 10ms, not 10s, but I'll give it a try.
Argh I totally missed that 🙈. Thanks for updating.
ryanemerson
requested changes
Mar 24, 2021
danberindei
force-pushed
the
ISPN-4996_zero_capacity_node
branch
from
8b4b839
to
f854140
Compare
* Delay initial topology until there is at least one node with capacityFactor>0 * Update ConditionFuture to allow duplicate predicates * Do not try to fetch listeners from other joiners
danberindei
force-pushed
the
ISPN-4996_zero_capacity_node
branch
from
f854140
to
bd955f8
Compare
|
Thanks @danberindei |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-4996
with capacityFactor>0