ISPN-12879 Pluggable TransportFactory for the Hot Rod client #9172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oraNod
reviewed
Mar 26, 2021
client/hotrod-client/src/main/java/org/infinispan/client/hotrod/configuration/package-info.java
Outdated
Show resolved
Hide resolved
tristantarrant
force-pushed
the
ISPN-12879/pluggable_eventloopgroup
branch
from
6578115
to
15ba801
Compare
|
Merged @oraNod 's edits as well as some javadoc additions |
oraNod
approved these changes
Mar 31, 2021
wburns
reviewed
Mar 31, 2021
| * <td><b>infinispan.client.hotrod.transport_factory</b></td> | ||
| * <td>String</td> | ||
| * <td>{@link org.infinispan.client.hotrod.impl.transport.netty.DefaultTransportFactory}</td> | ||
| * <td>Specifies the transport factory to use.</td> |
There was a problem hiding this comment.
Probably should mention class name?
...ient/src/main/java/org/infinispan/client/hotrod/configuration/ConfigurationChildBuilder.java
Show resolved
Hide resolved
| /** | ||
| * Creates a new {@link SocketChannel} | ||
| */ | ||
| Class<? extends SocketChannel> socketChannel(); |
tristantarrant
force-pushed
the
ISPN-12879/pluggable_eventloopgroup
branch
2 times, most recently
from
063d12b
to
85d71cf
Compare
|
@wburns I've addressed the issues. |
|
Checkstyle failure. |
wburns
approved these changes
Apr 1, 2021
tristantarrant
force-pushed
the
ISPN-12879/pluggable_eventloopgroup
branch
from
85d71cf
to
df0f635
Compare
|
Damn, fixed it |
|
Integrated into master, thanks @tristantarrant ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-12879