ISPN-12895 Upgrade to protostream 4.4.0.Beta3

[anistor]

https://issues.redhat.com/browse/ISPN-12895

Adds protostream-types module as a maven dependency and registers by default (in HR client and server) some schemas defined by it:

• for java collections
• for some java util/math: UUID, BigDecimal...

[ryanemerson]

@anistor org.infinispan.commons.dataconversion.StandardConversionsTest.testOctetStreamToJavaConversion looks related:

Expected: an instance of org.infinispan.commons.dataconversion.EncodingException
     but: <java.lang.IllegalArgumentException: Invalid wire type 7 in tag 23> is a java.lang.IllegalArgumentException
Stacktrace was: java.lang.IllegalArgumentException: Invalid wire type 7 in tag 23
 at org.infinispan.protostream.descriptors.WireType.fromTag(WireType.java:67)
 at org.infinispan.protostream.impl.TagReaderImpl$Decoder.readTag(TagReaderImpl.java:281)
 at org.infinispan.protostream.impl.TagReaderImpl.readTag(TagReaderImpl.java:98)
 at org.infinispan.protostream.WrappedMessage.readMessage(WrappedMessage.java:365)
 at org.infinispan.protostream.WrappedMessage.read(WrappedMessage.java:351)
 at org.infinispan.protostream.ProtobufUtil.fromWrappedByteArray(ProtobufUtil.java:129)
 at org.infinispan.commons.marshall.ImmutableProtoStreamMarshaller.objectFromByteBuffer(ImmutableProtoStreamMarshaller.java:31)
 at org.infinispan.commons.marshall.AbstractMarshaller.objectFromByteBuffer(AbstractMarshaller.java:82)
 at org.infinispan.commons.dataconversion.StandardConversions.convertOctetStreamToJava(StandardConversions.java:142)
 at org.infinispan.commons.dataconversion.StandardConversionsTest.testOctetStreamToJavaConversion(StandardConversionsTest.java:111)
 at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.base/java.lang.reflect.Method.invoke(Method.java:566)
 at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
 at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
 at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
 at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
 at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
 at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
 at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
 at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
 at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
 at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:405)
 at org.apache.maven.surefire.junitcore.pc.InvokerStrategy.schedule(InvokerStrategy.java:54)
 at org.apache.maven.surefire.junitcore.pc.Scheduler.schedule(Scheduler.java:362)
 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
 at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
 at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
 at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
 at org.junit.runners.Suite.runChild(Suite.java:128)
 at org.junit.runners.Suite.runChild(Suite.java:27)
 at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
 at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:405)
 at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
 at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
 at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
 at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
 at java.base/java.lang.Thread.run(Thread.java:834)

[anistor]

Indeed, when decoding errors occur the thrown exception happens a little earlier and is of different type. Will be fixed in next release.

[pruivo]

@anistor are you going to release a 4.4.0.Final before we cut 12.1?

[anistor]

should be ready now. Beta3 released (because beta2 was broken). No Final yet @pruivo

[anistor]

The question is, should protostream-types dependecy be marked optional in all non-server modules ? [later edit: Optional or not, does not matter much. Let's merge as is.]

[karesti]

@anistor can this be merged ?

[anistor]

Just fixed the conflict in RemoteCacheManager. should be fine now. Let's merge it once CI finishes.

[anistor]

merged