ISPN-12918 Rest stats requests block the Netty IO thread #9219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wburns
reviewed
Apr 7, 2021
server/rest/src/main/java/org/infinispan/rest/resources/MetricsResource.java
Outdated
Show resolved
Hide resolved
Process metrics endpoint requests on a blocking executor thread.
danberindei
force-pushed
the
ISPN-12918_stats_blocking
branch
from
c037959
to
5591086
Compare
|
Updated @wburns I'm not sure why BlockHound didn't catch it, we have an integration test that should touch this API: |
|
Integrated into master, thanks @danberindei ! |
|
@wburns found out why BlockHound didn't detect it: the only test for REST metrics is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-12918
Process metrics endpoint requests on a blocking executor thread.