ISPN-12933 Remove Bloom filters map in CacheRequestProcessor #9229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danberindei
force-pushed
the
ISPN-12933_bloom_cacheinfo
branch
from
0182515
to
f0ccc90
Compare
danberindei
commented
Apr 12, 2021
| BloomFilter<byte[]> priorFilter = bloomFilters.putIfAbsent(header.cacheName, bloomFilter); | ||
| assert priorFilter == null; | ||
| boolean filterAdded = cacheInfo.setBloomFilter(bloomFilter); | ||
| assert filterAdded; |
There was a problem hiding this comment.
@wburns I kept the logic here, but it doesn't feel right to me: addClientListener will be called multiple times per cache, at least once for each near cache client connecting to this server.
|
Unless, I am missing something this change will not work. The reason is we need to store a bloom filter per connection per cache. The cache info is stored for all connections per cache. Otherwise, you will have multiple clients bloom filters conflicting with each other. |
|
You're right Will, I didn't realize there was a separate CacheRequestProcessor per connection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-12933