ISPN-12937 Expiring counters #9508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oraNod
reviewed
Sep 13, 2021
There was a problem hiding this comment.
@pruivo A few doc suggestions. There is one section of the counters doc that duplicates/repeats the schema content. We could handle this at a later stage, but if you wanted to remove all the duplicated attributes from the doc and point to the schema in an Additional resources section like so:
[role="_additional-resources"]
.Additional resources
* link:{configdocroot}[{brandname} schema reference]
that might make life easier than updating schema + docs. It's up to you. Cheers.
counter/src/main/resources/schema/infinispan-counters-config-13.0.xsd
Outdated
Show resolved
Hide resolved
* Added an option to configure a lifespan for strong counters. When the counter is expired, it is reset to its initial value.
pruivo
force-pushed
the
t_12937_counter_expiration
branch
from
7be5a8a
to
e6e2ef1
Compare
Documentation improvements Co-authored-by: Don Naro <dnaro@redhat.com>
pruivo
force-pushed
the
t_12937_counter_expiration
branch
from
3023d47
to
a152dc4
Compare
oraNod
approved these changes
Sep 17, 2021
oraNod
reviewed
Sep 17, 2021
|
Think I will integrate, but @pruivo if you want to make another PR with the doc changes here as necessary would be great. |
|
Integrated into main, thanks @pruivo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
counter is expired, it is reset to its initial value.
https://issues.redhat.com/browse/ISPN-12937