ISPN-1869 If maxEntries set without eviction strategy, default to LIRS #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,6 +81,10 @@ void validate() { | |||
| log.warn("FIFO strategy is deprecated, LRU will be used instead"); | |||
| if (strategy.isEnabled() && maxEntries <= 0) | |||
| throw new ConfigurationException("Eviction maxEntries value cannot be less than or equal to zero if eviction is enabled"); | |||
| if (maxEntries > 0 && !strategy.isEnabled()) { | |||
| strategy = EvictionStrategy.LIRS; | |||
| log.debugf("Max entries configured (%d) without eviction strategy. Override strategy to be %s", maxEntries, strategy); | |||
There was a problem hiding this comment.
"Overriding strategy to be ... "? The log message you're printing out reads like an instruction that the user needs to override the strategy, not that it is being overridden.
There was a problem hiding this comment.
Sorry, it was meant to be: "Overriding strategy to be..." - I'll reword it
|
@maniksurtani updated commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-1869
5.1.x branch: t_1869_5