Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-13389 delete by query docs #9595

Merged
merged 1 commit into from Oct 20, 2021
Merged

ISPN-13389 delete by query docs #9595

merged 1 commit into from Oct 20, 2021

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Oct 13, 2021

@oraNod oraNod added the Documentation Pull request containing only documentation changes label Oct 13, 2021
@gustavocoding
Copy link

gustavocoding commented Oct 13, 2021 •
edited

@oraNod please ask @anistor review, he wrote the feature :)

I haven't look into it yet

oh nvm he's copied already ;)

@oraNod
Copy link
Contributor Author

oraNod commented Oct 13, 2021

@oraNod please ask @anistor review, he wrote the feature :)

I haven't look into it yet

oh nvm he's copied already ;)

@gustavonalle Yep. I did remove some of the [discrete] tags from 2nd level headings and made a few general changes to the query docs that I thought you might want to inspect. Cheers.

@anistor
Copy link
Member

anistor commented Oct 14, 2021

2 comments, otherwise LGTM!

@oraNod oraNod requested a review from anistor October 14, 2021 08:43
@oraNod
Copy link
Contributor Author

oraNod commented Oct 14, 2021

thanks @anistor I've made those two changes and squashed

@anistor anistor merged commit 7a3d579 into infinispan:main Oct 20, 2021
@anistor
Copy link
Member

anistor commented Oct 20, 2021

Merged! Thanks @oraNod !

@oraNod oraNod deleted the ISPN-13389/delete-by-query branch January 24, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavocoding gustavocoding Awaiting requested review from gustavocoding

@tristantarrant tristantarrant Awaiting requested review from tristantarrant

@anistor anistor Awaiting requested review from anistor

Assignees
No one assigned
Labels
Documentation Pull request containing only documentation changes
Projects
None yet
Milestone
No milestone
3 participants
@oraNod @gustavocoding @anistor