[13.0.x] ISPN-13430 IRAC tombstones are leaking #9629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danberindei
reviewed
Nov 5, 2021
Tombstones are required to detect conflicts with removed keys and they can be removed when there is no pending update from any site. In this PR, the primary owner queries all sites and, if all sites do not have any update pending for that key, it removes the tombstone from the primary owner and backup owners.
danberindei
approved these changes
Nov 5, 2021
|
Merged, thanks Pedro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tombstones are required to detect conflicts with removed keys and they
can be removed when there are no pending updates from any site.
In this PR, the primary owner queries all sites and, if all sites do not
have any update pending for that key, it removes the tombstone from the
primary owner and backup owners.
https://issues.redhat.com/browse/ISPN-13430